librustc: Fix the issue with labels shadowing variable names by making #14797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue number is incorrect: #12512 |
| (50, Typeof, "typeof"); | ||
| (51, Unsized, "unsized"); | ||
| (52, Yield, "yield"); | ||
| (53, Do, "do"); |
|
Could you also add |
the leading quote part of the identifier for the purposes of hygiene. This adopts @jbclements' solution to rust-lang#14539. I'm not sure if this is a breaking change or not. Closes rust-lang#12512. [breaking-change]
|
@bors: retry |
ftxqxd
added a commit
to ftxqxd/rust
that referenced
this pull request
Jun 16, 2014
rustdoc was previously formatting lifetimes with two apostrophes, presumably as a result of rust-lang#14797.
bors
added a commit
that referenced
this pull request
Jun 16, 2014
rustdoc was previously formatting lifetimes with two apostrophes, presumably as a result of #14797.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
fix: Fix perf regression from symbol index refactor Should fix the regressions introduced by rust-lang/rust-analyzer#14715 by partially rolling back the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the leading quote part of the identifier for the purposes of hygiene.
This adopts @jbclements' solution to #12512.
I'm not sure if this is a breaking change or not.
[breaking-change]
r? @alexcrichton