Skip to content

[beta] Clippy backport #146438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

[beta] Clippy backport #146438

merged 1 commit into from
Sep 11, 2025
+14 −3

Conversation

@flip1995
Copy link
Member

@flip1995 flip1995 commented Sep 11, 2025

Only a single commit to backport:

We'd like to get this ICE fix in a release earlier.

r? Mark-Simulacrum

@Jarcho @flip1995
Do not attempt to compute size of a type with escaping lifetimes (rus…
4b3008c 
…t-lang#15434)

A type with escaping bound vars cannot be wrapped in a dummy binder
during size computation.

Fixes rust-lang/rust-clippy#15429

changelog: [`zero_sized_hashmap_values`]: fix ICE in types with escaping
lifetimes

r? Jarcho

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_SUMMARY_START -->

### Summary Notes

- [Beta
nomination](rust-lang/rust-clippy#15434 (comment))
by [samueltardieu](https://github.com/samueltardieu)

*Managed by `@rustbot`—see
[help](https://forge.rust-lang.org/triagebot/note.html) for details*

<!-- TRIAGEBOT_SUMMARY_END -->
<!-- TRIAGEBOT_END -->
@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels Sep 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@flip1995 flip1995 mentioned this pull request Sep 11, 2025
Merged
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 11, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

📌 Commit 4b3008c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2025
@Zalathar
Copy link
Member

Zalathar commented Sep 11, 2025

I'm assuming this should go ahead sooner rather than later.

@bors p=5

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

⌛ Testing commit 4b3008c with merge f946d4d...

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f946d4d to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2025
@bors bors merged commit f946d4d into rust-lang:beta Sep 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

6 participants

@flip1995 @rustbot @Mark-Simulacrum @bors @Zalathar @Jarcho