-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Add a CI job that runs a subset of UI tests with the GCC backend #146414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI job that runs a subset of UI tests with the GCC backend #146414
Conversation
|
We can also specify the rust/src/ci/github-actions/jobs.yml Line 345 in 5d41f7c
|
e2d0466 to
2c2dac0
Compare
This comment has been minimized.
This comment has been minimized.
dfd72e4 to
bbdbe70
Compare
This comment has been minimized.
This comment has been minimized.
6bcf347 to
3a3bcf7
Compare
This comment has been minimized.
This comment has been minimized.
3a3bcf7 to
0efa10e
Compare
|
Error in ui tests: Seems like something went wrong with the build/install of libgccjit. Any idea @Kobzol? I thought libgccjit was built with bootstrap if |
|
Is the .so actually in the load path? For some reason the GCC backend works differently than clif for me locally and I often find I need to manually append |
|
Arf, it's the usual case of "it works locally for me". :-/ Gonna try to investigate if it's something wrong with paths. |
|
Seems like we don't copy the |
…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? `@GuillaumeGomez`
…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? ``@GuillaumeGomez``
…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? ```@GuillaumeGomez```
0efa10e to
7d861fe
Compare
This comment has been minimized.
This comment has been minimized.
Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang/rust#146414. r? ```@GuillaumeGomez```
|
So I didn't think of testing without the GCC backend. ^^' |
|
Let's try again. :') @bors r=Kobzol p=6 |
…obzol Add a CI job that runs a subset of UI tests with the GCC backend Part of rust-lang/compiler-team#891. r? `@Kobzol`
|
💔 Test failed - checks-actions |
|
Hum weird. I can't access the logs. Oh well. @bors retry |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing fb24b04 (parent) -> 2f7620a (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 2f7620a5ccfea7d59d1f500e2a2e59cf1c867a1b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (2f7620a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.864s -> 475.635s (0.16%) |
Ignore more failing ui tests for GCC backend Needed for rust-lang/rust#146414. r? ``@Kobzol``
Initialize llvm submodule if not already the case to run citool While working on rust-lang/rust#146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? ``@Kobzol``
Part of rust-lang/compiler-team#891.
r? @Kobzol