[DONT MERGE] externally implementable items #146348

jdonszelmann · 2025-09-08T21:04:17Z

Supersedes #140010
Tracking issue: #125418

Getting started:

#![feature(eii)]

#[eii(eii1)]
pub fn decl1(x: u64) 
// body optional (it's the default)
{
    println!("default {x}");
}

// in another crate, maybe
#[eii1]
pub fn decl2(x: u64) {
    println!("explicit {x}");
}

fn main() {
    decl1(4);
}

jdonszelmann · 2025-09-08T21:12:23Z

compiler/rustc_passes/src/reachable.rs

        // `SymbolExportLevel::Rust` export level but may end up being exported in dylibs.
        || codegen_attrs.flags.contains(CodegenFnAttrFlags::USED_COMPILER)
        || codegen_attrs.flags.contains(CodegenFnAttrFlags::USED_LINKER)
+        // Right now, the only way to get "foreign item symbol aliases" is by being an EII-implementation.


TODO: do we need this:

option 1: we do and implement our own reachability analysis based on it separate from RUSTC_STD_INTERNAL_SYMBOL.

~~option 2: we don't cause we also use RUSTC_STD_INTERNAL_SYMBOL on all EIIs. In that case we should rename STD_INTERNAL_SYMBOL~~

option 3: same as option 2 but maybe we shouldn't use RUSTC_STD_INTERNAL_SYMBOL in the first place; we leave it as-is and create a new flag thta's like it but specifically for EIIs and named something else like RUSTC_USED_BY_NONDIRECT_DEP_CRATE or whatever nicer name we can think of that (as long as it doesn't use STD since it's not really specific to that anymore)

despite STD_INTERNAL_SYMBOL working, and we can test with it for a bit, this is not the way we should do it. i.e. not option 2.

jdonszelmann · 2025-09-08T21:14:02Z

tests/ui/eii/default/local_crate_explicit.rs

+
+#[eii(eii1)]
+pub fn decl1(x: u64) {
+    //~^ WARN function `decl1` is never used


It took me a little bit to decide what is the expected behavior here. We might want to remove this warning. Defaults are in some way expected to be unused. However, here we can prove it because the explicit impl is in the same crate hence the warning.

removing the warning actually makes the code a tiny bit trickier

jdonszelmann · 2025-09-09T20:10:50Z

@bors2 try @rust-timer queue

[DONT MERGE] externally implementable items

rust-bors · 2025-09-09T22:16:01Z

☀️ Try build successful (CI)
Build commit: d5a6633 (d5a66337e06d3b77a1ab8f6793055535195c3ae9, parent: 364da5d88d772fa40fb20353443595385443ac25)

rust-timer · 2025-09-09T23:40:37Z

Finished benchmarking commit (d5a6633): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 1.5%]	19
Regressions ❌ (secondary)	0.4%	[0.1%, 1.0%]	44
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	4
All ❌✅ (primary)	0.3%	[0.1%, 1.5%]	19

Max RSS (memory usage)

Results (primary 1.7%, secondary 3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.6%, 2.3%]	6
Regressions ❌ (secondary)	4.7%	[1.1%, 11.2%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.9%, -1.2%]	2
All ❌✅ (primary)	1.7%	[0.6%, 2.3%]	6

Cycles

Results (primary 3.1%, secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.2%	[2.5%, 3.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-4.1%, -2.0%]	9
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	93
Regressions ❌ (secondary)	0.1%	[0.0%, 0.3%]	61
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	93

Bootstrap: 468.052s -> 471.14s (0.66%)
Artifact size: 387.52 MiB -> 390.25 MiB (0.71%)

jdonszelmann · 2025-09-10T02:44:26Z

Well, shit. I think I know some fixes but I hoped this wouldn't happen

compiler/rustc_hir_analysis/src/check/wfcheck.rs

bors · 2025-09-14T15:11:53Z

☔ The latest upstream changes (presumably #145881) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-09-17T12:03:50Z

☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

compiler/rustc_hir_analysis/src/check/compare_eii.rs

bors · 2025-10-16T06:46:33Z

☔ The latest upstream changes (presumably #146221) made this pull request unmergeable. Please resolve the merge conflicts.

…pe checking

EII collection queries

rust-log-analyzer · 2025-10-22T11:10:58Z

The job x86_64-gnu-gcc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [ui] tests/ui/editions/never-type-fallback.rs#e2021 ... ok
test [ui] tests/ui/editions/unsafe-attr-edition-span.rs#e2021 ... ok
test [ui] tests/ui/editions/unsafe-attr-edition-span.rs#e2024 ... ok
test [ui] tests/ui/editions/never-type-fallback.rs#e2024 ... ok
test [ui] tests/ui/eii/cross_crate_wrong_ty.rs ... ok
test [ui] tests/ui/eii/cross_crate.rs ... ok
test [ui] tests/ui/eii/codegen_single_crate.rs ... FAILED
test [ui] tests/ui/eii/codegen_cross_crate.rs ... FAILED
test [ui] tests/ui/eii/default/local_crate.rs ... FAILED
test [ui] tests/ui/eii/default/local_crate_explicit.rs ... FAILED
test [ui] tests/ui/eii/default/call_default.rs ... FAILED
test [ui] tests/ui/eii/default/call_impl.rs ... FAILED
test [ui] tests/ui/eii/errors.rs ... ok
test [ui] tests/ui/eii/duplicate/duplicate1.rs ... ok
test [ui] tests/ui/eii/privacy2.rs ... ok
test [ui] tests/ui/eii/duplicate/duplicate2.rs ... ok
test [ui] tests/ui/eii/privacy1.rs ... FAILED
test [ui] tests/ui/eii/subtype_1.rs ... ok
test [ui] tests/ui/eii/subtype_3.rs ... ok
test [ui] tests/ui/eii/subtype_2.rs ... ok
test [ui] tests/ui/eii/subtype_4.rs ... ok
test [ui] tests/ui/eii/unsafe_impl_ok.rs ... ok
test [ui] tests/ui/eii/unsafe_impl_err.rs ... ok
test [ui] tests/ui/eii/wrong_ret_ty.rs ... ok
test [ui] tests/ui/eii/wrong_ty.rs ... ok
test [ui] tests/ui/eii/wrong_target.rs ... ok
test [ui] tests/ui/eii/wrong_ty_2.rs ... ok
test [ui] tests/ui/empty/empty-comment.rs ... ok
test [ui] tests/ui/empty/empty-attributes.rs ... ok
test [ui] tests/ui/empty/empty-linkname.rs ... ok
test [ui] tests/ui/eii/duplicate/duplicate3.rs ... ok
test [ui] tests/ui/empty/empty-never-array.rs ... ok
test [ui] tests/ui/empty/empty-macro-use.rs ... ok
test [ui] tests/ui/empty/empty-struct-braces-expr.rs ... ok
test [ui] tests/ui/empty/empty-struct-braces-pat-1.rs ... ok
test [ui] tests/ui/empty/empty-struct-braces-pat-2.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-doc_masked.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-doc_notable_trait.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-effective-target-features.rs#default ... ok
test [ui] tests/ui/feature-gates/feature-gate-effective-target-features.rs#feature ... ok
test [ui] tests/ui/feature-gates/feature-gate-eii-internals.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-eii.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-exhaustive-patterns.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-ergonomic-clones.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-explicit-extern-abis.rs#current ... ok
test [ui] tests/ui/feature-gates/feature-gate-explicit-extern-abis.rs#future_feature ... ok
test [ui] tests/ui/feature-gates/feature-gate-explicit-extern-abis.rs#current_feature ... ok
---
---- [ui] tests/ui/eii/codegen_single_crate.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/eii/codegen_single_crate.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_single_crate/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustcoGFOuv/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bdynamic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-263465a51fef9918.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-*.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcoGFOuv/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_single_crate/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: hello
           >>> referenced by fake.c
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_single_crate/a.codegen_single_crate.d714f39b1622a531-cgu.0.rcgu.o:(codegen_single_crate::main::h3a59f14c0c7de01b)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error
------------------------------------------

---- [ui] tests/ui/eii/codegen_single_crate.rs stdout end ----
---- [ui] tests/ui/eii/codegen_cross_crate.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/eii/codegen_cross_crate.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_cross_crate/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_cross_crate/auxiliary" "-O"
stdout: none
--- stderr -------------------------------
error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustcfBG2ie/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_cross_crate/auxiliary/libcodegen2.rlib" "-Wl,-Bdynamic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-263465a51fef9918.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-*.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcfBG2ie/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_cross_crate/auxiliary" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_cross_crate/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: decl1
           >>> referenced by fake.c
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/codegen_cross_crate/a.codegen_cross_crate.af5b9a5664e07c02-cgu.0.rcgu.o:(codegen_cross_crate::main::hc496279e8d4df038)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error
------------------------------------------

---- [ui] tests/ui/eii/codegen_cross_crate.rs stdout end ----
---- [ui] tests/ui/eii/default/local_crate.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/eii/default/local_crate.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/local_crate/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustcnaQ5LY/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bdynamic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-263465a51fef9918.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-*.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcnaQ5LY/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/local_crate/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: decl1
           >>> referenced by fake.c
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/local_crate/a.local_crate.465a9d8cb614c192-cgu.0.rcgu.o:(local_crate::main::h82d0e1b84ed3244a)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error
------------------------------------------

---- [ui] tests/ui/eii/default/local_crate.rs stdout end ----
---- [ui] tests/ui/eii/default/local_crate_explicit.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/eii/default/local_crate_explicit.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/local_crate_explicit/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
warning: function `decl1` is never used
##[warning]  --> /checkout/tests/ui/eii/default/local_crate_explicit.rs:6:8
   |
LL | pub fn decl1(x: u64) {
   |        ^^^^^
   |
   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default

error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustcqJTXpd/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bdynamic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-263465a51fef9918.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-*.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcqJTXpd/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/local_crate_explicit/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: decl1
           >>> referenced by fake.c
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/local_crate_explicit/a.local_crate_explicit.e4b4dfe0eed95e5b-cgu.0.rcgu.o:(local_crate_explicit::main::h0f67957eedeef90b)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error; 1 warning emitted
------------------------------------------

---- [ui] tests/ui/eii/default/local_crate_explicit.rs stdout end ----
---- [ui] tests/ui/eii/default/call_default.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/eii/default/call_default.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_default/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_default/auxiliary"
stdout: none
--- stderr -------------------------------
error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustcjnpExT/symbols.o" "<2 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_default/auxiliary/libdecl_with_default.rlib" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcjnpExT/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_default/auxiliary" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_default/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: decl1
           >>> referenced by fake.c
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_default/a.call_default.e65edcad8a79f346-cgu.0.rcgu.o:(call_default::main::h2374fdba4a031467)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error
------------------------------------------

---- [ui] tests/ui/eii/default/call_default.rs stdout end ----
---- [ui] tests/ui/eii/default/call_impl.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/eii/default/call_impl.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_impl/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_impl/auxiliary"
stdout: none
--- stderr -------------------------------
error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustc9KLo4v/symbols.o" "<2 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_impl/auxiliary/{libimpl1,libdecl_with_default}.rlib" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustc9KLo4v/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_impl/auxiliary" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_impl/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: decl1
           >>> referenced by fake.c
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/default/call_impl/a.call_impl.84c521ed2ec1c8e6-cgu.0.rcgu.o:(call_impl::main::hb5179d65ef7249e4)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error
------------------------------------------

---- [ui] tests/ui/eii/default/call_impl.rs stdout end ----
---- [ui] tests/ui/eii/privacy1.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/eii/privacy1.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/privacy1/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/privacy1/auxiliary"
stdout: none
--- stderr -------------------------------
error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustca3LSPj/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/privacy1/auxiliary/libcodegen1.rlib" "-Wl,-Bdynamic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-263465a51fef9918.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-*.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustca3LSPj/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/privacy1/auxiliary" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/privacy1/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: decl1
           >>> referenced by fake.c
           >>>               codegen1.codegen1.79c2ab5f9ddba2c9-cgu.0.rcgu.o:(codegen1::local_call_decl1::hef22ca0cc9acedd0) in archive /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/privacy1/auxiliary/libcodegen1.rlib
           
           rust-lld: error: undefined symbol: decl2
           >>> referenced by fake.c
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/eii/privacy1/a.privacy1.c762a65e2a5a438e-cgu.0.rcgu.o:(privacy1::main::hf427a2a60776b8db)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error
------------------------------------------

---- [ui] tests/ui/eii/privacy1.rs stdout end ----

failures:
    [ui] tests/ui/eii/codegen_single_crate.rs
    [ui] tests/ui/eii/codegen_cross_crate.rs
    [ui] tests/ui/eii/default/local_crate.rs
    [ui] tests/ui/eii/default/local_crate_explicit.rs
    [ui] tests/ui/eii/default/call_default.rs
    [ui] tests/ui/eii/default/call_impl.rs
    [ui] tests/ui/eii/privacy1.rs

test result: FAILED. 19248 passed; 7 failed; 734 ignored; 0 measured; 0 filtered out; finished in 758.39s

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
Bootstrap failed while executing `--stage 2 test tests --test-codegen-backend gcc --skip tests/coverage --skip tests/coverage-run-rustdoc --skip tests/rustdoc --skip tests/rustdoc-gui --skip tests/rustdoc-js --skip tests/rustdoc-js-std --skip tests/rustdoc-json --skip tests/rustdoc-ui --set rust.codegen-backends=["llvm","gcc"]`

For more information how to resolve CI failures of this job, visit this link.

This comment has been minimized.

Sign in to view

jdonszelmann commented Sep 8, 2025

View reviewed changes

jdonszelmann force-pushed the eiiv3 branch from 178052a to 613c3aa Compare September 8, 2025 21:55

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the eiiv3 branch from 613c3aa to 745aae2 Compare September 8, 2025 22:09

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the eiiv3 branch from 745aae2 to e1292e5 Compare September 8, 2025 23:57

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the eiiv3 branch from e1292e5 to e33356a Compare September 9, 2025 04:07

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the eiiv3 branch from e33356a to f2d2adf Compare September 9, 2025 18:59

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 9, 2025

Auto merge of #146348 - jdonszelmann:eiiv3, r=<try>

d5a6633

[DONT MERGE] externally implementable items

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 9, 2025

jdonszelmann commented Sep 10, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/check/wfcheck.rs Outdated Show resolved Hide resolved

jdonszelmann force-pushed the eiiv3 branch from d228c51 to 32c0eee Compare September 15, 2025 19:17

lcnr reviewed Sep 17, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs Outdated Show resolved Hide resolved

lcnr reviewed Sep 17, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs Outdated Show resolved Hide resolved

lcnr reviewed Sep 17, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/check/compare_eii.rs Outdated Show resolved Hide resolved

lcnr reviewed Sep 17, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/check/compare_eii.rs Outdated Show resolved Hide resolved

lcnr reviewed Sep 17, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/check/compare_eii.rs Show resolved Hide resolved

jdonszelmann force-pushed the eiiv3 branch from 32c0eee to 07ed1fd Compare October 7, 2025 15:06

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the eiiv3 branch from 07ed1fd to 3b7f016 Compare October 16, 2025 10:22

This comment has been minimized.

Sign in to view

jdonszelmann added 15 commits October 20, 2025 13:44

EII tests

feb61de

TEMP: fixes error codes in non-codegen tests. those work after the ty…

3b91dc6

…pe checking

EII ast changes

9cfa496

EII (builtin) macros in std

862d5be

EII add feature gate

df02ee1

EII nameres changes

91c0cb4

EII lowering

395ee73

EII collection queries

412b700

EII collection queries

make EII iteration faster

8da968d

EII type checking

255bc66

fix problems with type checking

b229066

EII new error code

cd8fccc

EII liveness analysis

ea335da

EII: generate aliases for implementations

7e37127

visibility using std_internal_symbol

3d9ebf4

jdonszelmann force-pushed the eiiv3 branch from 3b7f016 to 3d9ebf4 Compare October 22, 2025 10:00

[DONT MERGE] externally implementable items #146348

Are you sure you want to change the base?

[DONT MERGE] externally implementable items #146348

Conversation

jdonszelmann commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

jdonszelmann Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdonszelmann commented Sep 9, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Sep 9, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Sep 9, 2025

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

jdonszelmann commented Sep 10, 2025

Uh oh!

Uh oh!

bors commented Sep 14, 2025

Uh oh!

bors commented Sep 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Oct 16, 2025

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jdonszelmann commented Sep 8, 2025 •

edited

Loading

jdonszelmann Sep 8, 2025 •

edited

Loading