-
Couldn't load subscription status.
- Fork 13.9k
DynamicConfig: use canonical clone impl #146240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
|
I tried changing the manual Copy and Clone impls to a derive clause, but that ends up causing lots of unsatisfied trait bounds. I don't understand why that does not work. The single shared reference member should impl Copy, and the automatically derived impls should be identical to the manual impls AFAICT. Apparently I'm wrong about this somehow. Would love to understand! |
|
@bors r+ rollup |
|
Just using a derive will introduce a |
Rollup of 4 pull requests Successful merges: - #146200 (Simplify rustdoc-gui tester by calling directly browser-ui-test) - #146236 (gpu offload: change suspicious map into filter) - #146240 (DynamicConfig: use canonical clone impl) - #146251 (rustc_middle: clippy fixes) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #146240 - hkBst:query-1, r=cjgillot DynamicConfig: use canonical clone impl Fixes clippy warning: ```text warning: non-canonical implementation of `clone` on a `Copy` type --> compiler/rustc_query_impl/src/lib.rs:60:29 | 60 | fn clone(&self) -> Self { | _____________________________^ 61 | | DynamicConfig { dynamic: self.dynamic } 62 | | } | |_____^ help: change this to: `{ *self }` ```
Fixes clippy warning: