Skip to content

Fix tracing debug representation of steps without arguments in bootstrap #145454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2025
Merged

Fix tracing debug representation of steps without arguments in bootstrap #145454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/bootstrap/src/core/builder/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1839,9 +1839,14 @@ pub fn pretty_step_name<S: Step>() -> String {
/// Renders `step` using its `Debug` implementation and extract the field arguments out of it.
fn step_debug_args<S: Step>(step: &S) -> String {
let step_dbg_repr = format!("{step:?}");
let brace_start = step_dbg_repr.find('{').unwrap_or(0);
let brace_end = step_dbg_repr.rfind('}').unwrap_or(step_dbg_repr.len());
step_dbg_repr[brace_start + 1..brace_end - 1].trim().to_string()

// Some steps do not have any arguments, so they do not have the braces
match (step_dbg_repr.find('{'), step_dbg_repr.rfind('}')) {
(Some(brace_start), Some(brace_end)) => {
step_dbg_repr[brace_start + 1..brace_end - 1].trim().to_string()
}
_ => String::new(),
}
}

fn pretty_print_step<S: Step>(step: &S) -> String {
Expand Down
Loading