Skip to content

[COMPILETEST-UNTANGLE 5/N] Test mode adjustments and other assorted cleanups #143823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 13, 2025
Merged

[COMPILETEST-UNTANGLE 5/N] Test mode adjustments and other assorted cleanups #143823

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33668c1
Remove outdated debugger version warning
jieyouxu Jul 5, 2025
832b627
Move `string_enum` to `util` module
jieyouxu Jul 12, 2025
b4dfd51
Do not allow defaults for `Mode` and `Config`
jieyouxu Jul 12, 2025
4aad9ab
Rename `Mode` to `TestMode`
jieyouxu Jul 12, 2025
b9ae117
Do not glob-reexport `TestMode` variants
jieyouxu Jul 12, 2025
6f8a7f0
Make rustdoc-gui-test dummy compiletest config purpose explicit
jieyouxu Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/tools/compiletest/src/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ string_enum! {
}
}

impl Default for Mode {
fn default() -> Self {
Mode::Ui
}
}

impl Mode {
pub fn aux_dir_disambiguator(self) -> &'static str {
// Pretty-printing tests could run concurrently, and if they do,
Expand Down Expand Up @@ -151,7 +145,7 @@ pub enum Sanitizer {
///
/// FIXME: audit these options to make sure we are not hashing less than necessary for build stamp
/// (for changed test detection).
#[derive(Debug, Default, Clone)]
#[derive(Debug, Clone)]
Copy link
Member Author

@jieyouxu jieyouxu Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: I was wondering what a default Config even means, turns out it's simply unused. Ditto on test mode.

pub struct Config {
/// Some test [`Mode`]s support [snapshot testing], where a *reference snapshot* of outputs (of
/// `stdout`, `stderr`, or other form of artifacts) can be compared to the *actual output*.
Expand Down