std: introduce path normalize methods at top of `std::path` by xizheyin · Pull Request #142957 · rust-lang/rust

xizheyin · 2025-06-24T10:34:18Z

Mention other methods that call conponents and canonicalize that fully normalize path. And fix two typo.

r? libs

ibraheemdev · 2025-07-06T23:22:51Z

Given the discussion on the issue, I think it would make more sense to have an overview in the top-level std::path documentation rather than intra-linking everything. You can open a separate PR for the typos if you wish to get that merged sooner.

xizheyin · 2025-07-07T07:07:57Z

@rustbot ready

I added a section Path normalization on top of std::Path.

ibraheemdev · 2025-08-28T23:37:07Z

Going to pass this one on because I'm not sure when I'll have time to get to it. r? libs

tgross35 · 2025-09-02T20:48:06Z

library/std/src/path.rs

+//! - [`PartialEq<Path>`], [`PartialOrd<Path>`], and [`Ord<Path>`] implementations
+//!   perform the same normalization for comparison
+//! - [`Path::has_root`] and [`PathBuf::push`] also apply this normalization
+//!


Since they all say they do the same normalization, it would probably be good to move that part outside of the list. Maybe roughly:

Several methods in this module perform basic path normalization by disregarding repeated separators, non-leading `.` components, and trailing separators. These include: - Methods for iteration, such as [`Path::components`] and [`Path::iter`] - Methods for inspection, such as [`Path::has_root`] - Comparisons using [`PartialEq`]` and [`PartialOrd`] [`Path::join`] and [`PathBuf::push`] also disregard trailing slashes.

I moved push and join out since I think they don't really interact with anything other than the trailing separator?

Ord is missing?

- Comparisons using [`PartialEq`], [`PartialOrd`], and [`Ord`]

I revise the doc. Sorry for late response. :)

library/std/src/path.rs

rustbot · 2026-02-09T10:25:56Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

xizheyin

@rustbot ready

View changes since this review

xizheyin · 2026-02-09T10:28:55Z

library/std/src/path.rs

+//! - [`PartialEq<Path>`], [`PartialOrd<Path>`], and [`Ord<Path>`] implementations
+//!   perform the same normalization for comparison
+//! - [`Path::has_root`] and [`PathBuf::push`] also apply this normalization
+//!


Ord is missing?

- Comparisons using [`PartialEq`], [`PartialOrd`], and [`Ord`]

I revise the doc. Sorry for late response. :)

tgross35

LGTM, thanks!

View changes since this review

tgross35 · 2026-02-09T10:34:14Z

@bors r+ rollup

rust-bors · 2026-02-09T10:34:18Z

📌 Commit 88c296a has been approved by tgross35

It is now in the queue for this repository.

std: introduce path normalize methods at top of `std::path` Closes rust-lang#142931 Mention other methods that call `conponents` and `canonicalize` that fully normalize path. And fix two typo. r? libs

Rollup of 12 pull requests Successful merges: - #152388 (`rust-analyzer` subtree update) - #151613 (Align `ArrayWindows` trait impls with `Windows`) - #152134 (Set crt_static_allow_dylibs to true for Emscripten target) - #152166 (cleanup some more things in `proc_macro::bridge`) - #152236 (compiletest: `-Zunstable-options` for json targets) - #152287 (Fix an ICE in the vtable iteration for a trait reference in const eval when a supertrait not implemented) - #142957 (std: introduce path normalize methods at top of `std::path`) - #145504 (Add some conversion trait impls) - #152131 (Port rustc_no_implicit_bounds attribute to parser.) - #152315 (fix: rhs_span to rhs_span_new) - #152327 (Check stalled coroutine obligations eagerly) - #152377 (Rename the query system's `JobOwner` to `ActiveJobGuard`, and include `key_hash`)

Rollup merge of #142957 - xizheyin:142931, r=tgross35 std: introduce path normalize methods at top of `std::path` Closes #142931 Mention other methods that call `conponents` and `canonicalize` that fully normalize path. And fix two typo. r? libs

rustbot assigned ibraheemdev Jun 24, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 24, 2025

This comment has been minimized.

Sign in to view

xizheyin force-pushed the 142931 branch from 7d82b5a to 113877f Compare June 24, 2025 14:17

ibraheemdev added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2025

xizheyin force-pushed the 142931 branch from 113877f to 43db784 Compare July 7, 2025 07:05

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2025

xizheyin changed the title ~~std: mention other methods that normalize a path in normalize_lexically doc~~ std: introduce path normalize methods at top of std::path Jul 7, 2025

rustbot assigned tgross35 and unassigned ibraheemdev Aug 28, 2025

tgross35 requested changes Sep 2, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2025

std: introduce path normalize methods at top of std::path

88c296a

xizheyin force-pushed the 142931 branch from 43db784 to 88c296a Compare February 9, 2026 10:25

xizheyin commented Feb 9, 2026

View reviewed changes

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2026

tgross35 approved these changes Feb 9, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026

JonathanBrouwer mentioned this pull request Feb 9, 2026

Rollup of 3 pull requests #152386

Closed

JonathanBrouwer mentioned this pull request Feb 9, 2026

Rollup of 8 pull requests #152390

Closed

JonathanBrouwer mentioned this pull request Feb 9, 2026

Rollup of 12 pull requests #152391

Closed

JonathanBrouwer mentioned this pull request Feb 9, 2026

Rollup of 12 pull requests #152395

Closed

matthiaskrgr mentioned this pull request Feb 9, 2026

Rollup of 12 pull requests #152399

Merged

JonathanBrouwer mentioned this pull request Feb 9, 2026

Rollup of 17 pull requests #152400

Closed

rust-bors bot merged commit c15f4e0 into rust-lang:main Feb 9, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 9, 2026

Uh oh!

Conversation

xizheyin commented Jun 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ibraheemdev commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xizheyin commented Jul 7, 2025

Uh oh!

ibraheemdev commented Aug 28, 2025

Uh oh!

tgross35 Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Feb 9, 2026

Uh oh!

xizheyin left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xizheyin Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Feb 9, 2026

Uh oh!

rust-bors bot commented Feb 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xizheyin commented Jun 24, 2025 •

edited by rustbot

Loading

ibraheemdev commented Jul 6, 2025 •

edited

Loading

xizheyin left a comment •

edited by rustbot

Loading

tgross35 left a comment •

edited by rustbot

Loading