Skip to content

Fix comment on NoMangle #142922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Fix comment on NoMangle #142922

merged 1 commit into from
Jun 24, 2025

Conversation

@JonathanBrouwer
Copy link
Contributor

Fix comment on NoMangle.
This was discussed in comments of #142823 (comment) and #142921

@JonathanBrouwer
Fix comment on NoMangle
6ea79a1 
Signed-off-by: Jonathan Brouwer <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 23, 2025
@JonathanBrouwer
Copy link
Contributor Author

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 6ea79a1 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@workingjubilee workingjubilee mentioned this pull request Jun 23, 2025
Merged
@aDotInTheVoid
Copy link
Member

Thanks!

bors added a commit that referenced this pull request Jun 24, 2025
@bors
Auto merge of #142929 - workingjubilee:rollup-4p3ypz1, r=workingjubilee
99b18d6 
Rollup of 9 pull requests

Successful merges:

 - #140985 (Change `core::iter::Fuse`'s `Default` impl to do what its docs say it does)
 - #141324 (std: sys: random: uefi: Provide rdrand based fallback)
 - #142134 (Reject unsupported `extern "{abi}"`s consistently in all positions)
 - #142784 (Add codegen timing section)
 - #142827 (Move error code explanation removal check into tidy)
 - #142873 (Don't suggest changing a  method inside a expansion)
 - #142908 (Fix install-template.sh for Solaris tr)
 - #142922 (Fix comment on NoMangle)
 - #142923 (fix `-Zmin-function-alignment` on functions without attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1569f14 into rust-lang:master Jun 24, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 24, 2025
rust-timer added a commit that referenced this pull request Jun 24, 2025
@rust-timer
Unrolled build for #142922
688c6ad 
Rollup merge of #142922 - JonathanBrouwer:fix-rustdoc-comment, r=jdonszelmann

Fix comment on NoMangle

Fix comment on NoMangle.
This was discussed in comments of #142823 (comment) and #142921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JonathanBrouwer @rustbot @jdonszelmann @bors @aDotInTheVoid @GuillaumeGomez