Skip to content

use lower case to match other error messages #139285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025
Merged

use lower case to match other error messages #139285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c2a322
use lower case to match other error messages
tshepang Apr 2, 2025
842da5c
structure the message
tshepang Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions compiler/rustc_session/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,10 +1423,12 @@ pub fn build_target_config(
}
target
}
Err(e) => early_dcx.early_fatal(format!(
"Error loading target specification: {e}. \
Run `rustc --print target-list` for a list of built-in targets"
)),
Err(e) => {
let mut err =
early_dcx.early_struct_fatal(format!("error loading target specification: {e}"));
err.help("run `rustc --print target-list` for a list of built-in targets");
err.emit();
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_target/src/spec/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3516,7 +3516,7 @@ impl Target {
Err("the `i586-pc-windows-msvc` target has been removed. Use the `i686-pc-windows-msvc` target instead.\n\
Windows 10 (the minimum required OS version) requires a CPU baseline of at least i686 so you can safely switch".into())
} else {
Err(format!("Could not find specification for target {target_tuple:?}"))
Err(format!("could not find specification for target {target_tuple:?}"))
}
}
TargetTuple::TargetJson { ref contents, .. } => {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-make/target-specs/rmake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ fn main() {
.input("foo.rs")
.target("my-invalid-platform.json")
.run_fail()
.assert_stderr_contains("Error loading target specification");
.assert_stderr_contains("error loading target specification");
rustc()
.input("foo.rs")
.target("my-incomplete-platform.json")
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/errors/wrong-target-spec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@

fn main() {}

//~? ERROR Error loading target specification: Could not find specification for target "x86_64_unknown-linux-musl"
//~? ERROR error loading target specification: could not find specification for target "x86_64_unknown-linux-musl"
4 changes: 3 additions & 1 deletion tests/ui/errors/wrong-target-spec.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
error: Error loading target specification: Could not find specification for target "x86_64_unknown-linux-musl". Run `rustc --print target-list` for a list of built-in targets
error: error loading target specification: could not find specification for target "x86_64_unknown-linux-musl"
|
= help: run `rustc --print target-list` for a list of built-in targets

Loading