Improve Lifetime::suggestion
#139046
Merged
Improve Lifetime::suggestion
#139046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
nnethercote
force-pushed
the
hir-Lifetime-better
branch
from
be80b19 to
effd5cc
Compare
This comment has been minimized.
This comment has been minimized.
nnethercote
force-pushed
the
hir-Lifetime-better
branch
from
effd5cc to
3eda3db
Compare
|
☔ The latest upstream changes (presumably #139826) made this pull request unmergeable. Please resolve the merge conflicts. |
nnethercote
force-pushed
the
hir-Lifetime-better
branch
from
3eda3db to
5eb8a5f
Compare
|
Details in individual commits. cc @shepmaster |
shepmaster
reviewed
Apr 28, 2025
lcnr
reviewed
May 1, 2025
lcnr
reviewed
May 1, 2025
We have coverage for `Foo` and `Foo<T>` but not for `Foo<>`. This commit adds it. Note that the output has bogus syntax: `impl Foo'a, >`
`Path<>` needs to be distinguished from `Path<T>`. This commit does that, improving some error messages.
lcnr
added
S-waiting-on-author
nnethercote
force-pushed
the
hir-Lifetime-better
branch
from
5eb8a5f to
d42edee
Compare
|
Ok, I have reduced the PR to perturb the carets in the error messages less. It now only makes the changes necessary to fix the malformed error messages. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
VlaDexa
added a commit
to VlaDexa/rust
that referenced
this pull request
May 2, 2025
…=lcnr Improve `Lifetime::suggestion` r? `@lcnr`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2025
Rollup of 12 pull requests Successful merges: - rust-lang#134034 (handle paren in macro expand for let-init-else expr) - rust-lang#137474 (pretty-print: Print shebang at the top of the output) - rust-lang#138872 (rustc_target: RISC-V `Zfinx` is incompatible with `{ILP32,LP64}[FD]` ABIs) - rust-lang#139046 (Improve `Lifetime::suggestion`) - rust-lang#139206 (std: use the address of `errno` to identify threads in `unique_thread_exit`) - rust-lang#139608 (Clarify `async` block behaviour) - rust-lang#139847 (Delegate to inner `vec::IntoIter` from `env::ArgsOs`) - rust-lang#140159 (Avoid redundant WTF-8 checks in `PathBuf`) - rust-lang#140197 (Document breaking out of a named code block) - rust-lang#140389 (Remove `avx512dq` and `avx512vl` implication for `avx512fp16`) - rust-lang#140430 (Improve test coverage of HIR pretty printing.) - rust-lang#140507 (rustc_target: RISC-V: feature addition batch 3) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2025
Rollup merge of rust-lang#139046 - nnethercote:hir-Lifetime-better, r=lcnr Improve `Lifetime::suggestion` r? ``@lcnr``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lcnr