Rollup of 9 pull requests #139009

jhpratt · 2025-03-27T01:02:28Z

Successful merges:

Suggest {to,from}_ne_bytes for transmutations between arrays and integers, etc #136083 (Suggest {to,from}_ne_bytes for transmutations between arrays and integers, etc)
Add mipsel maintainer #138624 (Add mipsel maintainer)
Update wg-prio triagebot config #138935 (Update wg-prio triagebot config)
Un-bury chapters from the chapter list in rustc book #138946 (Un-bury chapters from the chapter list in rustc book)
Implement lint against using Interner and InferCtxtLike in random compiler crates #138964 (Implement lint against using Interner and InferCtxtLike in random compiler crates)
Don't deaggregate InvocationParent just to reaggregate it again #138977 (Don't deaggregate InvocationParent just to reaggregate it again)
Collect items referenced from var_debug_info #138980 (Collect items referenced from var_debug_info)
Use the correct binder scope for elided lifetimes in assoc consts #138985 (Use the correct binder scope for elided lifetimes in assoc consts)
Always emit native-static-libs note, even if it is empty #138987 (Always emit native-static-libs note, even if it is empty)

r? @ghost
@rustbot modify labels: rollup

…gers, etc

…piler crates

The collection is limited to full debuginfo builds to match behavior of FunctionCx::compute_per_local_var_debug_info.

Suggest {to,from}_ne_bytes for transmutations between arrays and integers, etc implements rust-lang#136067 Rust has helper methods for many kinds of safe transmutes, for example integer<->bytes. This is a lint against using transmute for these cases. ```rs fn bytes_at_home(x: [u8; 4]) -> u32 { transmute(x) } // other examples transmute::<[u8; 2], u16>(); transmute::<[u8; 8], f64>(); transmute::<u32, [u8; 4]>(); transmute::<char, u32>(); transmute::<u32, char>(); ``` It would be handy to suggest `u32::from_ne_bytes(x)`. This is implemented for `[u8; _]` -> `{float int}` This also implements the cases: `fXX` <-> `uXX` = `{from_bits, to_bits}` `uXX` -> `iXX` via `cast_unsigned` and `cast_signed` {`char` -> `u32`, `bool` -> `n8`} via `from` `u32` -> `char` via `from_u32_unchecked` (note: notes `from_u32().unwrap()`) (contested) `u8` -> `bool` via `==` (debatable)

…ntainer, r=jieyouxu Add mipsel maintainer

…config, r=lqd Update wg-prio triagebot config This completes the Zulip channel renaming after rust-lang/compiler-team#848 Just nits: fixed a documentation link and the name of the Zulip channel for prioritization alerts. r? ```@davidtwco```

…ieyouxu Un-bury chapters from the chapter list in rustc book This PR moves the "Platform Support" section to the bottom of rustc chapter book, as to un-burry chapters from the chapter list, which where hidden by the wall of targets. | Before | After | |--------|-------| | ![image](https://github.com/user-attachments/assets/92769307-eadb-4d9d-bdbb-9e610207eb79) | ![image](https://github.com/user-attachments/assets/1834f5c5-a1e6-4674-9be2-1094d1376eda) | r? ```@jieyouxu```

… r=lcnr Implement lint against using Interner and InferCtxtLike in random compiler crates Often `Interner` defines similar methods to `TyCtxt` (but often simplified due to the simpler API surface of the type system layer for the new solver), which people will either unintentionally or intentionally import and use. Let's discourage that. r? lcnr

…ed, r=compiler-errors Don't deaggregate InvocationParent just to reaggregate it again Also makes it easier to add more things to it in the future (which I am doing in some local experiments, so not really a reason to do this just now, but I think this PR stands on its own).

…compiler-errors Collect items referenced from var_debug_info The collection is limited to full debuginfo builds to match behavior of FunctionCx::compute_per_local_var_debug_info. Fixes rust-lang#138942.

…ler-errors Use the correct binder scope for elided lifetimes in assoc consts Beyond diagnostics this has no real effect, and it's also just about a future incompat lint. But it causes ICEs in some refactorings that I'm doing, so trying to get it out of the way

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825. Retry of rust-lang#121216, finally got around to fixing the test, the errors in that PR were because `libcore` uses the `#[link]` attribute on MSVC. try-job: x86_64-msvc r? wesleywiser

jhpratt · 2025-03-27T01:02:35Z

@bors r+ rollup=never p=5

bors · 2025-03-27T01:02:38Z

📌 Commit b732db1 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-03-27T04:11:37Z

⌛ Testing commit b732db1 with merge e735f36...

Rollup of 9 pull requests Successful merges: - rust-lang#136083 (Suggest {to,from}_ne_bytes for transmutations between arrays and integers, etc) - rust-lang#138624 (Add mipsel maintainer) - rust-lang#138935 (Update wg-prio triagebot config) - rust-lang#138946 (Un-bury chapters from the chapter list in rustc book) - rust-lang#138964 (Implement lint against using Interner and InferCtxtLike in random compiler crates) - rust-lang#138977 (Don't deaggregate InvocationParent just to reaggregate it again) - rust-lang#138980 (Collect items referenced from var_debug_info) - rust-lang#138985 (Use the correct binder scope for elided lifetimes in assoc consts) - rust-lang#138987 (Always emit `native-static-libs` note, even if it is empty) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-03-27T04:33:22Z

The job dist-aarch64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] profiler_builtins test:false 0.026
error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:31:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
31   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `i8::cast_unsigned(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation
     |
     = note: `-D unnecessary-transmutes` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(unnecessary_transmutes)]`

error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:40:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
40   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `u8::cast_signed(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation

error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:31:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
31   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `i16::cast_unsigned(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation

error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:40:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
40   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `u16::cast_signed(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation

error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:31:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
31   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `i32::cast_unsigned(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation

error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:40:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
40   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `u32::cast_signed(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation

error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:31:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
31   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `i64::cast_unsigned(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation

error: unnecessary transmute
    --> library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/mod.rs:40:26
     |
24   | / macro_rules! impl_sign_conversions_neon {
25   | |     ($(($signed:ty, $unsigned:ty))*) => ($(
26   | |         impl AsUnsigned for $signed {
27   | |             type Unsigned = $unsigned;
...    |
40   | |                 unsafe { transmute(self) }
     | |                          ^^^^^^^^^^^^^^^ help: replace this with: `u64::cast_signed(self)`
...    |
43   | |     )*)
---
1115 | |     (i8, u8)
1116 | |     (i16, u16)
1117 | |     (i32, u32)
...    |
1190 | |     (uint8x8x4_t, int8x8x4_t)
1191 | | }
     | |_- in this macro invocation

error: unnecessary transmute
     --> library/core/src/../../stdarch/crates/core_arch/src/aarch64/neon/generated.rs:16008:14
      |
16008 |     unsafe { transmute(vaddvq_u64(transmute(a))) }
      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace this with: `u64::cast_signed(vaddvq_u64(transmute(a)))`

[RUSTC-TIMING] core test:false 14.995
error: could not compile `core` (lib) due to 9 previous errors
Build completed unsuccessfully in 0:12:22
[2025-03-27T04:33:08.160Z INFO  opt_dist::timer] Section `Stage 1 (Rustc PGO) > Build PGO instrumented rustc and LLVM` ended: FAIL (742.24s)`
---
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/std/src/../../backtrace/src/backtrace/mod.rs:66:14
   2: std::backtrace::Backtrace::create
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/std/src/backtrace.rs:331:13
   3: <anyhow::Error>::msg::<alloc::string::String>
             at /rust/deps/anyhow-1.0.95/src/backtrace.rs:27:14
   4: <opt_dist::exec::CmdBuilder>::run
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/exec.rs:80:17
   5: <opt_dist::exec::Bootstrap>::run
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/exec.rs:181:9
   6: opt_dist::execute_pipeline::{closure#1}::{closure#0}
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/main.rs:222:13
   7: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}::{closure#0}, ()>
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/timer.rs:111:22
   8: opt_dist::execute_pipeline::{closure#1}
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/main.rs:211:9
   9: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}, opt_dist::training::RustcPGOProfile>
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/timer.rs:111:22
  10: opt_dist::execute_pipeline
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/main.rs:208:29
  11: opt_dist::main
             at /rustc/e735f362905bea1ca304dcf8ad69f45fffb71945/src/tools/opt-dist/src/main.rs:408:18
  12: <fn() -> core::result::Result<(), anyhow::Error> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/core/src/ops/function.rs:250:5
  13: std::sys::backtrace::__rust_begin_short_backtrace::<fn() -> core::result::Result<(), anyhow::Error>, core::result::Result<(), anyhow::Error>>
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/std/src/sys/backtrace.rs:152:18
  14: std::rt::lang_start::<core::result::Result<(), anyhow::Error>>::{closure#0}
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/std/src/rt.rs:199:18
  15: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/core/src/ops/function.rs:284:13
  16: std::panicking::try::do_call
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/std/src/panicking.rs:587:40
  17: std::panicking::try
             at /rustc/f0cb41030579cd1a6f72bd23f38e677052d5d485/library/std/src/panicking.rs:550:19

bors · 2025-03-27T04:34:05Z

💔 Test failed - checks-actions

jieyouxu · 2025-03-27T10:36:19Z

#136083.
@bors r-

bend-n and others added 22 commits March 20, 2025 00:01

Suggest {to,from}_ne_bytes for transmutations between arrays and inte…

0abd167

…gers, etc

apply suggestion

c499a24

Add mipsel maintainer

f8791b2

rename

8e94318

update wg-prio triagebot config

2df6252

Move Platform Support section to the bottom of rustc chapter book

cd44399

hir::-ify internal lints

ca6dad3

Implement lint against using Interner and InferCtxtLike in random com…

14804d1

…piler crates

Stop using Interner in the compiler randomly

5f1e36f

Don't deaggregate InvocationParent just to reaggregate it again

781785d

Collect items referenced from var_debug_info

b04e5b4

The collection is limited to full debuginfo builds to match behavior of FunctionCx::compute_per_local_var_debug_info.

Use the correct binder scope for elided lifetimes in assoc consts

a830c59

Always emit native-static-libs note, even if it is empty

d1cd621

Rollup merge of rust-lang#138624 - LukasWoodtli:gardena/lw/mipsel-mai…

e44ed7b

…ntainer, r=jieyouxu Add mipsel maintainer

Rollup merge of rust-lang#138980 - tmiasko:collect-var-debug-info, r=…

86362c8

…compiler-errors Collect items referenced from var_debug_info The collection is limited to full debuginfo builds to match behavior of FunctionCx::compute_per_local_var_debug_info. Fixes rust-lang#138942.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 27, 2025

Zalathar mentioned this pull request Mar 27, 2025

Suggest {to,from}_ne_bytes for transmutations between arrays and integers, etc #136083

Merged

bend-n mentioned this pull request Mar 27, 2025

allow unnecessary transmutes in core_arch rust-lang/stdarch#1761

Merged

jieyouxu closed this Mar 27, 2025

jhpratt deleted the rollup-u8m255o branch March 27, 2025 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #139009

Rollup of 9 pull requests #139009

Uh oh!

jhpratt commented Mar 27, 2025

Uh oh!

jhpratt commented Mar 27, 2025

Uh oh!

bors commented Mar 27, 2025

Uh oh!

bors commented Mar 27, 2025

Uh oh!

rust-log-analyzer commented Mar 27, 2025

Uh oh!

bors commented Mar 27, 2025

Uh oh!

jieyouxu commented Mar 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Rollup of 9 pull requests #139009

Rollup of 9 pull requests #139009

Uh oh!

Conversation

jhpratt commented Mar 27, 2025

Uh oh!

jhpratt commented Mar 27, 2025

Uh oh!

bors commented Mar 27, 2025

Uh oh!

bors commented Mar 27, 2025

Uh oh!

rust-log-analyzer commented Mar 27, 2025

Uh oh!

bors commented Mar 27, 2025

Uh oh!

jieyouxu commented Mar 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants