Correctly escape hashtags when running invalid_rust_codeblocks lint
#136927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
|
I'll actually make a ui test to check this, not sure why I thought about a |
GuillaumeGomez
force-pushed
the
add-missing-hashtag-escape
branch
from
e3695d3 to
fa3e6a8
Compare
|
And done! :) |
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Feb 12, 2025
| // docs with the 2024 edition. | ||
| // Regression test for <https://github.com/rust-lang/rust/issues/136899>. | ||
|
|
||
| //@ check-pass |
There was a problem hiding this comment.
Suggested change
| //@ check-pass | |
| //@ check-pass | |
| //@ edition: 2024 |
UI tests default to Rust 2015
There was a problem hiding this comment.
I'd rather test both editions at once using revisions. Neither of them should warn, after all, and the combination of features and editions should be long-term easier to manage if we make a habit of parameterizing these tests whenever there's a chance of the edition affecting it.
As an example of how to do that, I wrote an edition-specific parameterized test for the span tweak:
There was a problem hiding this comment.
Hmm, I don't fully agree (after all, ## is Rust 2024 specific) but it doesn't hurt.
notriddle
reviewed
Feb 12, 2025
GuillaumeGomez
force-pushed
the
add-missing-hashtag-escape
branch
from
fa3e6a8 to
17cf100
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 13, 2025
…-escape, r=notriddle Correctly escape hashtags when running `invalid_rust_codeblocks` lint Fixes rust-lang#136899. We forgot to use `map_line` when we wrote this lint. r? `@notriddle`
This was referenced Feb 13, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2025
Rollup of 12 pull requests Successful merges: - rust-lang#134090 (Stabilize target_feature_11) - rust-lang#135025 (Cast allocas to default address space) - rust-lang#135841 (Reject `?Trait` bounds in various places where we unconditionally warned since 1.0) - rust-lang#136217 (Mark condition/carry bit as clobbered in C-SKY inline assembly) - rust-lang#136699 (std: replace the `FromInner` implementation for addresses with private conversion functions) - rust-lang#136806 (Fix cycle when debug-printing opaque types from RPITIT) - rust-lang#136807 (compiler: internally merge `PtxKernel` into `GpuKernel`) - rust-lang#136818 (Implement `read*_exact` for `std:io::repeat`) - rust-lang#136927 (Correctly escape hashtags when running `invalid_rust_codeblocks` lint) - rust-lang#136937 (Update books) - rust-lang#136945 (Add diagnostic item for `std::io::BufRead`) - rust-lang#136947 (Reinstate nnethercote in the review rotation.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2025
Rollup merge of rust-lang#136927 - GuillaumeGomez:add-missing-hashtag-escape, r=notriddle Correctly escape hashtags when running `invalid_rust_codeblocks` lint Fixes rust-lang#136899. We forgot to use `map_line` when we wrote this lint. r? ``@notriddle``
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Feb 15, 2025
Rollup of 12 pull requests Successful merges: - rust-lang#134090 (Stabilize target_feature_11) - rust-lang#135025 (Cast allocas to default address space) - rust-lang#135841 (Reject `?Trait` bounds in various places where we unconditionally warned since 1.0) - rust-lang#136217 (Mark condition/carry bit as clobbered in C-SKY inline assembly) - rust-lang#136699 (std: replace the `FromInner` implementation for addresses with private conversion functions) - rust-lang#136806 (Fix cycle when debug-printing opaque types from RPITIT) - rust-lang#136807 (compiler: internally merge `PtxKernel` into `GpuKernel`) - rust-lang#136818 (Implement `read*_exact` for `std:io::repeat`) - rust-lang#136927 (Correctly escape hashtags when running `invalid_rust_codeblocks` lint) - rust-lang#136937 (Update books) - rust-lang#136945 (Add diagnostic item for `std::io::BufRead`) - rust-lang#136947 (Reinstate nnethercote in the review rotation.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136899.
We forgot to use
map_linewhen we wrote this lint.r? @notriddle