Disable overflow_delimited_expr in edition 2024
#136312
Merged
+58
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/doc/style-guide cc @rust-lang/style Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
lmao @bors delegate=ytmimi |
|
✌️ @ytmimi, you can now approve this pull request! If @compiler-errors told you to " |
compiler-errors
added
beta-nominated
ytmimi
reviewed
Jan 30, 2025
Comment on lines
+947
to
949
| // FIXME: this test doesn't really exercise anything, since | ||
| // `overflow_delimited_expr` is disabled by default in edition 2024. | ||
| assert_eq!(config.overflow_delimited_expr(), false); |
There was a problem hiding this comment.
Might make sense to remove this test outright and the style_edition_defaults_overridden_from_cli test below, but I'm fine just adding the FIXME.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#132156 (When encountering unexpected closure return type, point at return type/expression) - rust-lang#133429 (Autodiff Upstreaming - rustc_codegen_ssa, rustc_middle) - rust-lang#136281 (`rustc_hir_analysis` cleanups) - rust-lang#136297 (Fix a typo in profile-guided-optimization.md) - rust-lang#136300 (atomic: extend compare_and_swap migration docs) - rust-lang#136310 (normalize `*.long-type.txt` paths for compare-mode tests) - rust-lang#136312 (Disable `overflow_delimited_expr` in edition 2024) - rust-lang#136313 (Filter out RPITITs when suggesting unconstrained assoc type on too many generics) - rust-lang#136323 (Fix a typo in conventions.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2025
Rollup merge of rust-lang#136312 - compiler-errors:overflow_delimited_expr-2024, r=ytmimi Disable `overflow_delimited_expr` in edition 2024 This reverts the style guide changes and sets the default to "false" in rustfmt for style edition 2024. r? `@ytmimi` cc `@rust-lang/style` `@rust-lang/rustfmt`
ehuss
added a commit
to ehuss/edition-guide
that referenced
this pull request
Jan 31, 2025
This has been dropped from the edition via rust-lang/rust#136312.
ehuss
added
the
beta-accepted
ehuss
pushed a commit
to ehuss/rust
that referenced
this pull request
Feb 1, 2025
…_expr-2024, r=ytmimi Disable `overflow_delimited_expr` in edition 2024 This reverts the style guide changes and sets the default to "false" in rustfmt for style edition 2024. r? `@ytmimi` cc `@rust-lang/style` `@rust-lang/rustfmt`
ehuss
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2025
[beta-1.85] backports * [Add `AsyncFn*` to `core` prelude](rust-lang#135852) * [Disable `overflow_delimited_expr` in edition 2024](rust-lang#136312) * [Disable some incorrect rust-analyzer diagnostics on beta](rust-lang#136236) * [fix: Fix #[rustc_deprecated_safe_2024]](rust-lang/rust-analyzer#19044) * [fix: Fix a bug where enum variants were not considered properly in type ns resolution](rust-lang/rust-analyzer#18976) * Update edition-guide * [Add alternatives for static-mut-refs](rust-lang/edition-guide#354) * [Remove rustfmt-overflow-delimited-expr](rust-lang/edition-guide#357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the style guide changes and sets the default to "false" in rustfmt for style edition 2024.
r? @ytmimi
cc @rust-lang/style @rust-lang/rustfmt