-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump compiler and tools to windows 0.59, bootstrap to 0.57 #135487
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
Some changes occurred in src/tools/compiletest cc @jieyouxu These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
Okay, As for ws2_32, maybe after #122362? |
Do you have more context you can share on this? Is this something we should block merging on perhaps? The changes in this PR look fine to me, but this seems at least good to either drop from the PR description (if not actually relevant here?) or rephrase (e.g., pointing to some issue for follow-up work)... |
No, this pr ready to review and merge, added note that will work on other imports in followup pr. |
@bors r+ |
…crum bump compiler and tools to windows 0.59, bootstrap to 0.57 This bumps compiler and tools to windows 0.59 (temporary dupes version, as `sysinfo` still depend on <= 0.57). Bootstrap bumps only to 0.57 (the same sysinfo dep). This additionally resolves my comment rust-lang#130874 (comment) Will work on it in follow up pr: There still some sus imports for `rustc_driver.dll` like ws2_32 or RoOriginateErrorW, but i will look at them later.
…crum bump compiler and tools to windows 0.59, bootstrap to 0.57 This bumps compiler and tools to windows 0.59 (temporary dupes version, as `sysinfo` still depend on <= 0.57). Bootstrap bumps only to 0.57 (the same sysinfo dep). This additionally resolves my comment rust-lang#130874 (comment) Will work on it in follow up pr: There still some sus imports for `rustc_driver.dll` like ws2_32 or RoOriginateErrorW, but i will look at them later.
@bors rollup=iffy (dep bumps) |
Rebased, other dep updates broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
☀️ Test successful - checks-actions |
Finished benchmarking commit (a24bdc6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -3.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 765.516s -> 763.897s (-0.21%) |
Why bump of windows-only deps (of compiler and bootstrap) changes binary size of linux artifacts? https://perf.rust-lang.org/compare.html?start=ed43cbcb882e7c06870abdd9305dc1f17eb9bab9&end=a24bdc60ce8b54ff5610793e8527eea84ce6fb6f&stat=size%3Alinked_artifact&nonRelevant=true&showRawData=true Weird. |
This bumps compiler and tools to windows 0.59 (temporary dupes version, as
sysinfo
still depend on <= 0.57).Bootstrap bumps only to 0.57 (the same sysinfo dep).
This additionally resolves my comment #130874 (comment)
Will work on it in follow up pr: There still some sus imports for
rustc_driver.dll
like ws2_32 or RoOriginateErrorW, but i will look at them later.