-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn rustc-dev-guide into a Josh subtree #134907
Conversation
This was renamed by rust-lang#116791.
* Fix some broken links under bootstrapping. * Fix more broken links for bootstrapping.
rust-lang#1960) * compiletest: specify which special env var and which particular CI job * compiletest: fix grammar and add link to Dockerfile
Signed-off-by: needsure <[email protected]>
The `-Z verbose` option has been renamed to `-Z verbose-internals` in commit b5d8361 [1] (PR rust-lang#119129 [2]). This commit updates the remaining `-Z verbose` to `-Z verbose-internals`. [1]: rust-lang@b5d8361 [2]: rust-lang#119129
Co-authored-by: Tshepang Mbambo <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Thanks! I think there is a small list of prerequisites to move forward:
|
You might also want to delete this line that updates the submodule, just in case someone in the future wants to get the test step running, to help avoid an obvious problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you!
☔ The latest upstream changes (presumably #134926) made this pull request unmergeable. Please resolve the merge conflicts. |
|
|
It was not working for a long time.
c025fd6
to
47e2baa
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Rebased. |
Thanks! @bors r+ |
@bors rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c528b8c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.9%, secondary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 764.563s -> 763.985s (-0.08%) |
Discussed on Zulip.
Accompanying rustc-dev-guide PR: rust-lang/rustc-dev-guide#2183
I didn't create a bootstrap step for rustc-dev-guide yet, because the rustc-dev-guide version that we currently use in this repo doesn't have linkcheck enabled and that fails tests.
The subtree starts with commit ad93c5f1c49f2aeb45f7a4954017b1e607df9f5e.
What I did:
r? ehuss