[experimental] shorten backtraces using debuginfo #134831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2024
[experimental] shorten backtraces using debuginfo cc rust-lang/compiler-team#818 r? `@ghost` `@rustbot` label S-experimental try-job: aarch64-apple
|
@bors delegate+ (for try jobs) |
This comment has been minimized.
This comment has been minimized.
|
i think rustc_middle is going to fail to compile, so @bors cancel try |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2024
[experimental] shorten backtraces using debuginfo cc rust-lang/compiler-team#818 r? `@ghost` `@rustbot` label S-experimental try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2024
[experimental] shorten backtraces using debuginfo cc rust-lang/compiler-team#818 r? `@ghost` `@rustbot` label S-experimental try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
☔ The latest upstream changes (presumably #135053) made this pull request unmergeable. Please resolve the merge conflicts. |
- give an error when `#[rustc_start/end_short_backtrace]` is used with `#[inline]` - update `short_ice-remove-middle-frames` to use the new attribute so that it's tested - don't ICE when debug logging
jyn514
added a commit
to jyn514/gimli
that referenced
this pull request
Jan 21, 2025
Often, consumers of a DWARF file will want to know if a given function has an attribute, either directly or indirectly. Currently, finding that information is tedious and prone to error. Add a helper function in gimli to make this easier. This does not attempt to have the maximum possible performance; consumers who care about that can still implement the logic themselves. In particular, the caches are recalculated each time `shared_attrs` is called, introducing an allocation. The logic works roughly as follows (inspired by [addr2line::Function::parse_children](https://github.com/gimli-rs/addr2line/blob/28ba2d45f2d22134915f55b46ddd6a039559366b/src/function.rs#L278)): - Create a cache of all DWARF units known to the `UnitRef` - Given an entry offset, iterate over all its attributes and pass them to a callback chosen by the caller. - For each indirect attribute, such as `DW_AT_abstract_origin`, follow the pointer to the abstract source and do the same thing again there. I have tested this downstream (see [rust-lang/rust#134831](rust-lang/rust#134831)), but I have not yet added unit tests. Let me know how you would like this to be tested.
rustbot
added
A-compiletest
8 tasks
|
i won't be working on this for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/compiler-team#818
r? @ghost
@rustbot label S-experimental
try-job: aarch64-apple