remove long-deprecated no-op attributes no_start and crate_id #134300
Conversation
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
rustbot
added
S-waiting-on-review
RalfJung
force-pushed
the
remove-dead-attrs
branch
2 times, most recently
from
e1e212d to
f9444bb
Compare
RalfJung
added
I-lang-nominated
|
@bors try |
RalfJung
added
I-lang-nominated
remove long-deprecated no-op attributes no_start and crate_id These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything.
RalfJung
added
the
S-waiting-on-team
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
(started an crater run because these attributes are stable, so they may be referenced even if they do nothing, seems safer to me) |
RalfJung
added
the
S-waiting-on-team
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
The crates.io regressions are all spurious. I sampled some of the github crate regressions and the ones I hit were also all spurious. So I think we can consider this a no-regression crater result. :) |
This comment was marked as resolved.
This comment was marked as resolved.
jieyouxu
added
I-lang-easy-decision
traviscross
removed
the
T-compiler
|
@rfcbot fcp merge |
|
Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
rfcbot
added
proposed-final-comment-period
|
@rfcbot reviewed |
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
traviscross
removed
the
I-lang-nominated
|
☔ The latest upstream changes (presumably #134299) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
force-pushed
the
remove-dead-attrs
branch
from
f9444bb to
a99778c
Compare
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134300 (remove long-deprecated no-op attributes no_start and crate_id) - rust-lang#134373 (Improve and expand documentation of pipes) - rust-lang#135934 (Include missing item in the 1.81 release notes) - rust-lang#136005 (ports last few library files to new intrinsic style) - rust-lang#136016 (Improve check-cfg expected names diagnostic) - rust-lang#136039 (docs: fix typo in std::pin overview) - rust-lang#136056 (Fix typo in const stability error message) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#134300 - RalfJung:remove-dead-attrs, r=chenyukang remove long-deprecated no-op attributes no_start and crate_id These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything. In fact they [apparently](rust-lang#64471 (comment)) have done nothing since pre-1.0, so... do we even need a crater run? Doesn't seem worth it.
These have emitted a deprecation warning since forever (#64471) and they already don't do anything. In fact they apparently have done nothing since pre-1.0, so... do we even need a crater run? Doesn't seem worth it.