sync: remove unsafe and add Send+Share to Deref (enabled by autoderef vtables) #13394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yay, thank you! There are two more of these in sync/lock.rs, do you want to take care of those as well? |
radford
changed the title
|
Done. |
|
@radford BTW, the email in the commits doesn't appear to be hooked up to your github account. |
|
@sfackler, I hooked it up; What does it affect? |
|
It allows GitHub to link from the commit to your account. E.g. look at the question mark next to your name in the top bar here: radford@84c2016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.