Target modifiers (special marked options) are recorded in metainfo #133138
+648
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
d99ff62 to
bd52a23
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
bd52a23 to
500600b
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/target-modifiers
branch
2 times, most recently
from
db91299 to
43e5956
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
43e5956 to
6793451
Compare
davidtwco
requested changes
Nov 21, 2024
rustbot
added
S-waiting-on-author
azhogin
force-pushed
the
azhogin/target-modifiers
branch
2 times, most recently
from
95f9595 to
9cd86c3
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
9cd86c3 to
97a8240
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
97a8240 to
8603b2b
Compare
davidtwco
reviewed
Dec 2, 2024
90 tasks
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
8603b2b to
95ffdf8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
90452da to
c8d56d3
Compare
bjorn3
reviewed
Jan 26, 2025
|
|
||
| if tcx.crate_types().contains(&CrateType::ProcMacro) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why are we ignoring target modifier compatibility when we ourself are a proc macro rather than ignoring target modifiers just for dependencies that are proc macros?
There was a problem hiding this comment.
Currently, both dependency proc macro and main proc macro are ignored for target modifiers.
As far as I understand, proc macro crate will not ever be executed during runtime. It is executed only during compilation, right?
There was a problem hiding this comment.
If the current crate is a proc macro and has a dependency on a non-proc-macro crate, then those are linked together and the target modifiers do need to match.
16 tasks
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
c8d56d3 to
a3a4327
Compare
|
@bors r=davidtwco,saethlin |
bors
added
S-waiting-on-bors
|
@bors rollup=iffy |
40 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2025
…davidtwco,saethlin Target modifiers (special marked options) are recorded in metainfo Target modifiers (special marked options) are recorded in metainfo and compared to be equal in different linked crates. PR for this RFC: rust-lang/rfcs#3716 Option may be marked as `TARGET_MODIFIER`, example: `regparm: Option<u32> = (None, parse_opt_number, [TRACKED TARGET_MODIFIER]`. If an TARGET_MODIFIER-marked option has non-default value, it will be recorded in crate metainfo as a `Vec<TargetModifier>`: ``` pub struct TargetModifier { pub opt: OptionsTargetModifiers, pub value_name: String, } ``` OptionsTargetModifiers is a macro-generated enum. Option value code (for comparison) is generated using `Debug` trait. Error example: ``` error: mixing `-Zregparm` will cause an ABI mismatch in crate `incompatible_regparm` --> $DIR/incompatible_regparm.rs:10:1 | LL | #![crate_type = "lib"] | ^ | = help: the `-Zregparm` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely = note: `-Zregparm=1` in this crate is incompatible with `-Zregparm=2` in dependency `wrong_regparm` = help: set `-Zregparm=2` in this crate or `-Zregparm=1` in `wrong_regparm` = help: if you are sure this will not cause problems, use `-Cunsafe-allow-abi-mismatch=regparm` to silence this error error: aborting due to 1 previous error ``` `-Cunsafe-allow-abi-mismatch=regparm,reg-struct-return` to disable list of flags.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
I have no idea how to fix those apple build problems. May I use "only-x86" in tests to avoid this problem? |
Yes, so long as you also comment alongside that directive that
|
…d compared to be equal in different crates
azhogin
force-pushed
the
azhogin/target-modifiers
branch
from
a3a4327 to
e3aa87a
Compare
|
@bors r=davidtwco,saethlin |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2025
…davidtwco,saethlin Target modifiers (special marked options) are recorded in metainfo Target modifiers (special marked options) are recorded in metainfo and compared to be equal in different linked crates. PR for this RFC: rust-lang/rfcs#3716 Option may be marked as `TARGET_MODIFIER`, example: `regparm: Option<u32> = (None, parse_opt_number, [TRACKED TARGET_MODIFIER]`. If an TARGET_MODIFIER-marked option has non-default value, it will be recorded in crate metainfo as a `Vec<TargetModifier>`: ``` pub struct TargetModifier { pub opt: OptionsTargetModifiers, pub value_name: String, } ``` OptionsTargetModifiers is a macro-generated enum. Option value code (for comparison) is generated using `Debug` trait. Error example: ``` error: mixing `-Zregparm` will cause an ABI mismatch in crate `incompatible_regparm` --> $DIR/incompatible_regparm.rs:10:1 | LL | #![crate_type = "lib"] | ^ | = help: the `-Zregparm` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely = note: `-Zregparm=1` in this crate is incompatible with `-Zregparm=2` in dependency `wrong_regparm` = help: set `-Zregparm=2` in this crate or `-Zregparm=1` in `wrong_regparm` = help: if you are sure this will not cause problems, use `-Cunsafe-allow-abi-mismatch=regparm` to silence this error error: aborting due to 1 previous error ``` `-Cunsafe-allow-abi-mismatch=regparm,reg-struct-return` to disable list of flags.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target modifiers (special marked options) are recorded in metainfo and compared to be equal in different linked crates.
PR for this RFC: rust-lang/rfcs#3716
Option may be marked as
TARGET_MODIFIER, example:regparm: Option<u32> = (None, parse_opt_number, [TRACKED TARGET_MODIFIER].If an TARGET_MODIFIER-marked option has non-default value, it will be recorded in crate metainfo as a
Vec<TargetModifier>:OptionsTargetModifiers is a macro-generated enum.
Option value code (for comparison) is generated using
Debugtrait.Error example:
-Cunsafe-allow-abi-mismatch=regparm,reg-struct-returnto disable list of flags.