Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit dangling pointers #132983

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Edit dangling pointers #132983

merged 4 commits into from
Jan 23, 2025

Conversation

Anthony-Eid
Copy link
Contributor

Closes: #132283

@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Urgau
Urgau reviewed Nov 13, 2024
View reviewed changes
compiler/rustc_lint/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_lint/src/lints.rs Outdated Show resolved Hide resolved
@Urgau
Copy link
Member

Urgau commented Nov 13, 2024

After making the suggested changes, you will need to update the tests expectations, that can be done with ./x.py test --stage 1 tests/lint/ --bless.

@rustbot author
r? Urgau

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@rustbot rustbot assigned Urgau and unassigned pnkfelix Nov 13, 2024
@Anthony-Eid
Copy link
Contributor Author

@Urgau Thank you for the fast feedback! I'll make the changes soon, I was having trouble understanding how everything worked. So I started reading the rust compiler book and was planning on fixing this once I was more confident in my understanding of the codebase.

@Urgau
Copy link
Member

Urgau commented Nov 13, 2024

The most relevant chapter is probably the one on #[derive(LintDiagnostic)], we also have a chapter on adding new tests which might be useful for updating the tests.

@Anthony-Eid Anthony-Eid force-pushed the dangling-pointers-lint branch from d605e95 to bab8a41 Compare December 5, 2024 11:12
@Anthony-Eid Anthony-Eid marked this pull request as ready for review December 5, 2024 11:12
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau
Copy link
Member

Urgau commented Dec 5, 2024

@Anthony-Eid the test output also need to be updated, that can be done with ./x.py test --stage 1 tests/ui/lint/ --bless.

@alex-semenyuk
Copy link
Member

@Anthony-Eid
Thanks for your contribution
From wg-triage. Could you please take a look comments above?

@Anthony-Eid
Copy link
Contributor Author

@alex-semenyuk Thank you for the reminder! I just updated the lints with ./x test --stage 1 tests/ui/lint/ --bless. Is there anything else that I should do?

@Urgau
Copy link
Member

Urgau commented Jan 22, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 22, 2025

📌 Commit 12214db has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#132983 - Anthony-Eid:dangling-pointers-lint…
5a36359 
…, r=Urgau

Edit dangling pointers

Closes: rust-lang#132283
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@bors
Auto merge of rust-lang#135891 - matthiaskrgr:rollup-vqfwp83, r=matth…
1a60b67 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#132983 (Edit dangling pointers )
 - rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
 - rust-lang#135409 (Fix ICE-133117: multiple never-pattern arm doesn't have false_edge_start_block)
 - rust-lang#135557 (Point at invalid utf-8 span on user's source code)
 - rust-lang#135596 (Properly note when query stack is being cut off)
 - rust-lang#135794 (Detect missing fields with default values and suggest `..`)
 - rust-lang#135814 (ci: use ghcr buildkit image)
 - rust-lang#135826 (Misc. `rustc_resolve` cleanups)
 - rust-lang#135837 (Remove test panic from File::open)
 - rust-lang#135856 (Library: Finalize dyn compatibility renaming)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@bors
Auto merge of rust-lang#135896 - matthiaskrgr:rollup-g6rv7za, r=matth…
a30f915 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#132983 (Edit dangling pointers )
 - rust-lang#135409 (Fix ICE-133117: multiple never-pattern arm doesn't have false_edge_start_block)
 - rust-lang#135557 (Point at invalid utf-8 span on user's source code)
 - rust-lang#135596 (Properly note when query stack is being cut off)
 - rust-lang#135794 (Detect missing fields with default values and suggest `..`)
 - rust-lang#135814 (ci: use ghcr buildkit image)
 - rust-lang#135826 (Misc. `rustc_resolve` cleanups)
 - rust-lang#135837 (Remove test panic from File::open)
 - rust-lang#135856 (Library: Finalize dyn compatibility renaming)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9206ba5 into rust-lang:master Jan 23, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

Explore possible suggestions for dangling_pointers_from_temporaries lint
7 participants
@Anthony-Eid @rustbot @rust-log-analyzer @Urgau @alex-semenyuk @bors @pnkfelix