Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific diagnostic for using macro_rules macro as attribute/derive #132949

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Add specific diagnostic for using macro_rules macro as attribute/derive #132949

merged 2 commits into from
Nov 23, 2024

Conversation

clubby789
Copy link
Contributor

Fixes #132928

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2024
@clubby789 clubby789 changed the title Add test for using macro_rules macro as attribute/derive Add specific diagnostic for using macro_rules macro as attribute/derive Nov 12, 2024
@clubby789 clubby789 force-pushed the macro-rules-attr-derive branch from 41875c7 to 6201d54 Compare November 12, 2024 14:35
fmease
fmease reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally 👍 but I have some comments

compiler/rustc_resolve/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_resolve/messages.ftl Outdated Show resolved Hide resolved
tests/ui/macros/macro-rules-as-derive-or-attr-issue-132928.stderr Outdated Show resolved Hide resolved
@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024
@clubby789 clubby789 force-pushed the macro-rules-attr-derive branch from 6201d54 to 4627db2 Compare November 22, 2024 16:49
@clubby789
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 22, 2024
@fmease
Copy link
Member

fmease commented Nov 23, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 23, 2024

📌 Commit 4627db2 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 23, 2024
@matthiaskrgr
Rollup merge of rust-lang#132949 - clubby789:macro-rules-attr-derive,…
42e25b4 
… r=fmease

Add specific diagnostic for using macro_rules macro as attribute/derive

Fixes rust-lang#132928
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 23, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@bors
Auto merge of rust-lang#133375 - matthiaskrgr:rollup-j9uf0mx, r=matth…
d819de9 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#127483 (Allow disabling ASan instrumentation for globals)
 - rust-lang#131505 (use `confstr(_CS_DARWIN_USER_TEMP_DIR, ...)` as a `TMPDIR` fallback on Darwin)
 - rust-lang#132949 (Add specific diagnostic for using macro_rules macro as attribute/derive)
 - rust-lang#133247 (Reduce integer `Display` implementation size)
 - rust-lang#133286 (Re-delay a resolve `bug` related to `Self`-ctor in patterns)
 - rust-lang#133332 (Mark `<[T; N]>::as_mut_slice` with the `const` specifier.)
 - rust-lang#133366 (Remove unnecessary bool from `ExpectedFound::new`)

Failed merges:

 - rust-lang#131859 (Update TRPL to add new Chapter 17: Async and Await)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu jieyouxu mentioned this pull request Nov 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@bors
Auto merge of rust-lang#133377 - jieyouxu:rollup-n536hzq, r=jieyouxu
826b673 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#127483 (Allow disabling ASan instrumentation for globals)
 - rust-lang#131505 (use `confstr(_CS_DARWIN_USER_TEMP_DIR, ...)` as a `TMPDIR` fallback on Darwin)
 - rust-lang#132949 (Add specific diagnostic for using macro_rules macro as attribute/derive)
 - rust-lang#133286 (Re-delay a resolve `bug` related to `Self`-ctor in patterns)
 - rust-lang#133332 (Mark `<[T; N]>::as_mut_slice` with the `const` specifier.)
 - rust-lang#133366 (Remove unnecessary bool from `ExpectedFound::new`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f7e3de3 into rust-lang:master Nov 23, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@rust-timer
Unrolled build for rust-lang#132949
2852c95 
Rollup merge of rust-lang#132949 - clubby789:macro-rules-attr-derive, r=fmease

Add specific diagnostic for using macro_rules macro as attribute/derive

Fixes rust-lang#132928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

Misleading error when attempting to use macro_rules as an attribute
4 participants
@clubby789 @rustbot @fmease @bors