Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note not to re-report crashes from crashes tests #132700

Merged
merged 1 commit into from
Nov 6, 2024
Merged

add note not to re-report crashes from crashes tests #132700

merged 1 commit into from
Nov 6, 2024

Conversation

matthiaskrgr
Copy link
Member

for reasons... 😅
r? @fmease

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

Could not assign reviewer from: fmease.
User(s) fmease are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2024
@matthiaskrgr
Copy link
Member Author

sad
r? @apiraino

@rustbot rustbot assigned apiraino and unassigned Mark-Simulacrum Nov 6, 2024
@fmease fmease assigned fmease and unassigned apiraino Nov 6, 2024
@fmease
Copy link
Member

fmease commented Nov 6, 2024

Ye, I'll unvacation myself soon

@fmease
Copy link
Member

fmease commented Nov 6, 2024

Thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 6, 2024

📌 Commit da5102c has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 6, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2024
@bors
Auto merge of rust-lang#132703 - GuillaumeGomez:rollup-tfuef34, r=Gui…
8549802 
…llaumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#132617 (Fix an extra newline in rendered std doc)
 - rust-lang#132698 (Remove unneeded fields in `scrape_examples::FindCalls`)
 - rust-lang#132700 (add note not to re-report crashes from `crashes` tests)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2024
@rust-timer
Unrolled build for rust-lang#132700
d3a8305 
Rollup merge of rust-lang#132700 - matthiaskrgr:plzno, r=fmease

add note not to re-report crashes from `crashes` tests

for reasons... 😅
r? `@fmease`
@bors bors merged commit 4c7e92f into rust-lang:master Nov 6, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @rustbot @fmease @bors @Mark-Simulacrum @apiraino