-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Remove outdated tidy license fixmes #132560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
|
I don't think we are doing vendoring for those workspaces and thus |
|
Quite possibly, I don't enough this space to know if you should do that instead. I mainly just saw the fixme could be resolved. Happy to instead remove the lines completely if that's desired. |
|
When I added those fixme's I didn't yet realize that checking licenses for these workspaces would cause tidy to fail when there is no internet. As far as I'm concerned these fixmes should just be removed. |
ce0555d to
b3fc11b
Compare
|
@bors r+ rollup |
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#126136 (Call the target libdir target libdir) - rust-lang#132516 (Add bad-reg inline assembly ui test for RISC-V and s390x) - rust-lang#132521 (replace manual time convertions with std ones, comptime time format parsing) - rust-lang#132560 (Remove outdated tidy license fixmes) - rust-lang#132563 (Modify `NonZero` documentation to reference the underlying integer type) - rust-lang#132574 (compiler: Directly use rustc_abi almost everywhere) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#132560 - Urgau:tidy-license-deps, r=onur-ozkan Remove outdated tidy license fixmes ~~This PR re-enables license dependency checking for:~~ - ~~the `backtrace` submodule~~ - ~~and the `portable-simd` subtree~~ ~~The `stdarch` submodule doesn't have a `Cargo.lock` yet so we can't re-enable it.~~ This PR removes outdated tidy license fixmes, rust-lang#132560 (comment). r? bootstrap
This PR re-enables license dependency checking for:thebacktracesubmoduleand theportable-simdsubtreeThestdarchsubmodule doesn't have aCargo.lockyet so we can't re-enable it.This PR removes outdated tidy license fixmes, #132560 (comment).
r? bootstrap