rustc_feature::Features: explain what that 'Option<Symbol>' is about #132098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Question: is it worth it to introduce a struct with named fields instead of a 3-tuple? The comments are good -- but the callsite would still see the 3-tuple only. |
|
Possibly... I went for the faster version due to a lack of time, but feel free to take over and do the struct thing :)
|
jieyouxu
reviewed
Oct 24, 2024
| /// Returns a list of triples with: | ||
| /// - feature gate name | ||
| /// - the span of the `#[feature]` attribute | ||
| /// - (for already stable features) the version since which it is stable | ||
| pub fn enabled_lang_features(&self) -> &Vec<(Symbol, Span, Option<Symbol>)> { |
There was a problem hiding this comment.
Discussion: not for this PR, but like
pub struct LangFeature {
name: Symbol,
attr_sp: Span,
stable_since: Option<Symbol>,
}
pub fn enabled_lang_features(&self) -> &Vec<LangFeature> { ... }There was a problem hiding this comment.
The type should probably be called EnabledLangFeature, but other than that -- yeah makes sense.
|
I'll see if it makes sense to package them into a struct in a follow-up. |
|
Thanks for the docs! r? jieyouxu |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 24, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#129248 (Taking a raw ref (`&raw (const|mut)`) of a deref of pointer (`*ptr`) is always safe) - rust-lang#131906 (rustdoc: adjust spacing and typography in header) - rust-lang#132084 (Consider param-env candidates even if they have errors) - rust-lang#132096 (Replace an FTP link in comments with an equivalent HTTPS link) - rust-lang#132098 (rustc_feature::Features: explain what that 'Option<Symbol>' is about) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 24, 2024
Rollup merge of rust-lang#132098 - RalfJung:features-since, r=jieyouxu rustc_feature::Features: explain what that 'Option<Symbol>' is about
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2024
Use `Enabled{Lang,Lib}Feature` instead of n-tuples
Instead of passing around e.g. `(gate_name, attr_span, stable_since)` 3-tuples for enabled lang features or `(gate_name, attr_span)` 2-tuples for enabled lib features, use `Enabled{Lang,Lib}Feature` structs with named fields.
Also did some minor code-golfing of involved iterator chains to hopefully make them easier to follow.
Follow-up to rust-lang#132098 (comment) cc `@RalfJung.`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
Rollup merge of rust-lang#132114 - jieyouxu:features-bundle, r=fee1-dead Use `Enabled{Lang,Lib}Feature` instead of n-tuples Instead of passing around e.g. `(gate_name, attr_span, stable_since)` 3-tuples for enabled lang features or `(gate_name, attr_span)` 2-tuples for enabled lib features, use `Enabled{Lang,Lib}Feature` structs with named fields. Also did some minor code-golfing of involved iterator chains to hopefully make them easier to follow. Follow-up to rust-lang#132098 (comment) cc `@RalfJung.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.