Fix most ui tests on emscripten target #131705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
|
Some changes occurred in src/tools/compiletest cc @jieyouxu This PR modifies If appropriate, please update |
Nice!
No requirement that you fix them in this PR. I expect the backtrace tests may get an ignore for emscripten. It sounds like the only one of particular interest is async-await/issue-60709.rs |
jieyouxu
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Thanks for the PR. I left some suggestions. The other failing tests are fine (i.e. not needed to be addressed in this PR). I would encourage opening a tracking issue for the remaining failing ui tests on emscripten targets for tracking purposes so they aren't lost when this PR is merged.
|
@rustbot author |
rustbot
added
S-waiting-on-author
To fix the linker errors, we need to set the output extension to `.js` instead of `.wasm`. Setting the output to a `.wasm` file puts Emscripten into standalone mode which is effectively a distinct target. We need to set the runner to be `node` as well. This fixes most of the ui tests. I fixed a few more tests with simple problems: - `intrinsics/intrinsic-alignment.rs` and `structs-enums/rec-align-u64.rs` -- Two `#[cfg]` macros match for Emscripten so we got a duplicate definition of `mod m`. - `issues/issue-12699.rs` -- Seems to hang so I disabled it - `process/process-sigpipe.rs` -- Not expected to work on Emscripten so I disabled it
hoodmane
force-pushed
the
fix-emscripten-tests
branch
from
236df30
to
1d6643c
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Oct 15, 2024
7 tasks
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
Thanks for the review @jieyouxu! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2024
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#129794 (uefi: Implement getcwd and chdir) - rust-lang#130568 (Make some float methods unstable `const fn`) - rust-lang#131521 (rename RcBox to RcInner for consistency) - rust-lang#131701 (Don't report `on_unimplemented` message for negative traits) - rust-lang#131705 (Fix most ui tests on emscripten target) - rust-lang#131733 (Fix uninlined_format_args in stable_mir) - rust-lang#131734 (Update `arm64e-apple-tvos` maintainer) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2024
Rollup merge of rust-lang#131705 - hoodmane:fix-emscripten-tests, r=jieyouxu Fix most ui tests on emscripten target To fix the linker errors, we need to set the output extension to `.js` instead of `.wasm`. Setting the output to a `.wasm` file puts Emscripten into standalone mode which is effectively a distinct target. We need to set the runner to be `node` as well. This fixes most of the ui tests. I fixed 4 additional tests with simple problems: - `intrinsics/intrinsic-alignment.rs` -- Two `#[cfg]` macros match for Emscripten so we got duplicate definition - `structs-enums/rec-align-u64.rs` -- same problem - `issues/issue-12699.rs` -- hangs so I disabled it - `process/process-sigpipe.rs` -- Not expected to work on Emscripten so I disabled it Resolves rust-lang#131666. There are 7 more failing tests. I'll try to investigate more and see if I can fix them or at least understand why they happen. - abi/numbers-arithmetic/return-float.rs (problem with [wasm treatment of noncanonical floats](https://webassembly.github.io/spec/core/exec/numerics.html#nan-propagation)?) - async-await/issue-60709.rs -- linker error related to memcpy. Possible Emscripten bug? - backtrace/dylib-dep.rs -- Says "Not supported" - backtrace/line-tables-only.rs -- Says "Not supported" - no_std/no-std-unwind-binary.rs -- compiler says `error: lang item required, but not found: eh_catch_typeinfo` - structs-enums/enum-rec/issue-17431-6.rs -- One of the two compiler errors is missing - test-attrs/test-passed.rs r?workingjubilee r?jieyouxu
workingjubilee
added
the
O-emscripten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the linker errors, we need to set the output extension to
.jsinstead of.wasm. Setting the output to a.wasmfile puts Emscripten into standalone mode which is effectively a distinct target. We need to set the runner to benodeas well.This fixes most of the ui tests. I fixed 4 additional tests with simple problems:
intrinsics/intrinsic-alignment.rs-- Two#[cfg]macros match for Emscripten so we got duplicate definitionstructs-enums/rec-align-u64.rs-- same problemissues/issue-12699.rs-- hangs so I disabled itprocess/process-sigpipe.rs-- Not expected to work on Emscripten so I disabled itResolves #131666.
There are 7 more failing tests. I'll try to investigate more and see if I can fix them or at least understand why they happen.
abi/numbers-arithmetic/return-float.rs (problem with wasm treatment of noncanonical floats?)
async-await/issue-60709.rs -- linker error related to memcpy. Possible Emscripten bug?
backtrace/dylib-dep.rs -- Says "Not supported"
backtrace/line-tables-only.rs -- Says "Not supported"
no_std/no-std-unwind-binary.rs -- compiler says
error: lang item required, but not found: eh_catch_typeinfostructs-enums/enum-rec/issue-17431-6.rs -- One of the two compiler errors is missing
test-attrs/test-passed.rs
r?workingjubilee r?jieyouxu