Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impossible obligations fast path #131491

Merged
merged 1 commit into from
Oct 10, 2024
Merged

impossible obligations fast path #131491

merged 1 commit into from
Oct 10, 2024

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 10, 2024

fixes the remaining performance regression in nalgebra for #130654

r? @compiler-errors

Fixes #124894

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative labels Oct 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2024

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr lcnr changed the title impossible obligations check fast path impossible obligations fast path Oct 10, 2024
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 10, 2024

📌 Commit d6fd45c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2024
@matthiaskrgr
Copy link
Member

I've added "Fixes #124894" to the pr body so that the fixed crashtest issue gets closed

@compiler-errors
Copy link
Member

danke schön

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#130625 (Fix a few relative paths in rustc doc)
 - rust-lang#131397 (fix/update teach_note from 'escaping mutable ref/ptr' const-check)
 - rust-lang#131479 (Apple: Avoid redundant `-Wl,-dylib` flag when linking)
 - rust-lang#131480 (Fix hardcoded strip path when cross-compiling from Linux to Darwin)
 - rust-lang#131482 (structurally resolve adts and tuples expectations too)
 - rust-lang#131484 (Add myself back to review rotation)
 - rust-lang#131491 (impossible obligations fast path)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1c62cff into rust-lang:master Oct 10, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
Rollup merge of rust-lang#131491 - lcnr:nalgebra-perrrrf, r=compiler-errors

impossible obligations fast path

fixes the remaining performance regression in nalgebra for rust-lang#130654

r? `@compiler-errors`

Fixes rust-lang#124894
@rustbot rustbot added this to the 1.83.0 milestone Oct 10, 2024
@lcnr lcnr deleted the nalgebra-perrrrf branch October 10, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: coherence: SizeOf MIR operator called for unsized type dyn Trait
6 participants