Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace manual verbose checks with Config::is_verbose #131061

Merged
merged 1 commit into from
Sep 30, 2024
Merged

replace manual verbose checks with Config::is_verbose #131061

merged 1 commit into from
Sep 30, 2024

Conversation

onur-ozkan
Copy link
Member

self-explanatory

@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 30, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Sep 30, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2024

📌 Commit fd1429a has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2024
@bors
Auto merge of rust-lang#131063 - matthiaskrgr:rollup-hfs3fo1, r=matth…
c3ce4e6 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#130895 (make type-check-4 asm tests about non-const expressions)
 - rust-lang#131057 (Reject leading unsafe in `cfg!(...)` and `--check-cfg`)
 - rust-lang#131060 (Drop conditionally applied cargo `-Zon-broken-pipe=kill` flags to fix stage 1 cargo rebuilds)
 - rust-lang#131061 (replace manual verbose checks with `Config::is_verbose`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5ba81d7 into rust-lang:master Sep 30, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2024
@rust-timer
Unrolled build for rust-lang#131061
fe74134 
Rollup merge of rust-lang#131061 - onur-ozkan:verbose-checks, r=Kobzol

replace manual verbose checks with `Config::is_verbose`

self-explanatory
@rustbot rustbot added this to the 1.83.0 milestone Sep 30, 2024
@onur-ozkan onur-ozkan deleted the verbose-checks branch September 30, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @Kobzol @bors @albertlarsan68