Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest adding missing braces in const block pattern #130751

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Suggest adding missing braces in const block pattern #130751

wants to merge 2 commits into from

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Sep 23, 2024 •
edited
Loading

Fixes #78168.

Builds upon work done in #78173.

TODO:

@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2024
camelid and others added 2 commits September 24, 2024 02:37
@camelid @GrigorenkoPV
Suggest adding missing braces in const block pattern
e4a9b8b 
Previously it would only suggest wrapping the code in braces in regular
expressions; now it does it in patterns too.

This is a squashed rebase of rust-lang#78173
@GrigorenkoPV
Move eating const back into parse_const_block
bb10afd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error for missing braces in const block
4 participants
@GrigorenkoPV @rustbot @BoxyUwU @camelid