Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the link_cfg feature as internal #130556

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Mark the link_cfg feature as internal #130556

merged 1 commit into from
Sep 19, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Sep 19, 2024 •
edited
Loading

This PR marks the link_cfg feature as internal because it's a perma-unstable feature, only used by core/stdand unwind.

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2024
@Urgau Urgau changed the title Make link_cfg feature internal Mark the link_cfg feature as internal Sep 19, 2024
jieyouxu
jieyouxu approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu jieyouxu assigned jieyouxu and unassigned wesleywiser Sep 19, 2024
@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 19, 2024

📌 Commit b67485e has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2024
@bors
Auto merge of rust-lang#130572 - matthiaskrgr:rollup-0q3qyg9, r=matth…
506f22b 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#128001 (Improve documentation for <integer>::from_str_radix)
 - rust-lang#130553 ([Clippy] Get rid of most `std` `match_def_path` usage, swap to diagnostic items.)
 - rust-lang#130554 (`pal::unsupported::process::ExitCode`: use an `u8` instead of a `bool`)
 - rust-lang#130556 (Mark the `link_cfg` feature as internal)
 - rust-lang#130558 (Support 128-bit atomics on s390x)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9f0d32c into rust-lang:master Sep 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2024
@rust-timer
Unrolled build for rust-lang#130556
e8c9599 
Rollup merge of rust-lang#130556 - Urgau:link_cfg_internal, r=jieyouxu

Mark the `link_cfg` feature as internal

This PR marks the `link_cfg` feature as internal because it's a perme-unstable feature, only used by `core`/`std`and `unwind`.
@Veykril Veykril mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Urgau @rustbot @jieyouxu @bors @wesleywiser