Remove redundant test typeid equality by subtyping #130482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
remove-known-bug-97156
branch
from
f27c6b7
to
65f8999
Compare
spastorino
changed the title
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2024
…iaskrgr Rollup of 2 pull requests Successful merges: - rust-lang#130481 (Remove uneeded PartialOrd bound in cmp::Ord::clamp) - rust-lang#130482 (Remove redundant test typeid equality by subtyping) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2024
Rollup merge of rust-lang#130482 - spastorino:remove-known-bug-97156, r=jackh726 Remove redundant test typeid equality by subtyping This known-bug label was a left over on rust-lang#118247 r? `@jackh726` This doesn't address rust-lang#110395, I didn't investigate about it yet.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 27, 2024
…iler-errors Cleanup some known-bug issues I went through most of the known-bug tests (except those under `tests/crashes`) and made sure the issue had the `S-bug-has-test` label and checked that the linked issue was open. This is a bunch of cleanups, mainly issues that have been closed and the tests should have been updated. Importantly, there are many known-bug tests linking to rust-lang#110395. This *probably* isn't right - that is a tracking issue. But I don't really know what the "right" thing to do here. Probably, most that are actually *supposed* to be tests for const trait need to be linked to *that* tracking issue. And any other tests that were mislabeled need to be handled accordingly e.g. rust-lang#130482. cc `@fee1-dead`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
Rollup merge of rust-lang#130718 - jackh726:known-bug-cleanup, r=compiler-errors Cleanup some known-bug issues I went through most of the known-bug tests (except those under `tests/crashes`) and made sure the issue had the `S-bug-has-test` label and checked that the linked issue was open. This is a bunch of cleanups, mainly issues that have been closed and the tests should have been updated. Importantly, there are many known-bug tests linking to rust-lang#110395. This *probably* isn't right - that is a tracking issue. But I don't really know what the "right" thing to do here. Probably, most that are actually *supposed* to be tests for const trait need to be linked to *that* tracking issue. And any other tests that were mislabeled need to be handled accordingly e.g. rust-lang#130482. cc `@fee1-dead`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This known-bug label was a left over on #118247
r? @jackh726
This doesn't address #110395, I didn't investigate about it yet.