Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete sub build directory "debug" to not delete the change-id file #130459

Merged
merged 1 commit into from
Sep 27, 2024
Merged

delete sub build directory "debug" to not delete the change-id file #130459

merged 1 commit into from
Sep 27, 2024

Conversation

onur-ozkan
Copy link
Member

Fixes #130449

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 17, 2024
@onur-ozkan onur-ozkan changed the title delete sub directory "debug" to not delete the change-id file delete sub build directory "debug" to not delete the change-id file Sep 17, 2024
albertlarsan68
albertlarsan68 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@albertlarsan68 albertlarsan68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2024

📌 Commit d2c58ec has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 27, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130934 - matthiaskrgr:rollup-4puticr, r=matth…
fa724e5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129087 (Stabilize `option_get_or_insert_default`)
 - rust-lang#130435 (Move Apple linker args from `rustc_target` to `rustc_codegen_ssa`)
 - rust-lang#130459 (delete sub build directory "debug" to not delete the change-id file)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)
 - rust-lang#130916 (Use `&raw` in the compiler)
 - rust-lang#130917 (Fix error span if arg to `asm!()` is a macro call)
 - rust-lang#130927 (update outdated comments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 56e5bfa into rust-lang:master Sep 27, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@rust-timer
Unrolled build for rust-lang#130459
f6fdc5e 
Rollup merge of rust-lang#130459 - onur-ozkan:rust-lang#130449, r=albertlarsan68

delete sub build directory "debug" to not delete the change-id file

Fixes rust-lang#130449
@onur-ozkan onur-ozkan deleted the #130449 branch September 27, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertlarsan68 albertlarsan68 albertlarsan68 approved these changes

Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

build/bootstrap/.last-warned-change-id gets removed by workaround for #125578
4 participants
@onur-ozkan @rustbot @albertlarsan68 @bors