Add test for nalgebra hang in coherence #130276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup thanks |
bors
added
S-waiting-on-bors
|
I wonder if we should also add this to the benchmark suite. We already saw some cases where a test hang lasting e.g. 2 hours was not discovered quickly, because the test run was still under our CI timeout and we have no automated monitoring for CI jobs suddenly taking way longer. |
|
I would be in favor of adding nalgebra to the benchmark suite. It would probably give us good signal on changes to the solver. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130101 (some const cleanup: remove unnecessary attributes, add const-hack indications) - rust-lang#130208 (Introduce `'ra` lifetime name.) - rust-lang#130263 (coverage: Simplify creation of sum counters) - rust-lang#130273 (more eagerly discard constraints on overflow) - rust-lang#130276 (Add test for nalgebra hang in coherence) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2024
Rollup merge of rust-lang#130276 - compiler-errors:nalgebra-hang, r=lcnr Add test for nalgebra hang in coherence r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? lcnr