-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstable feature usage metrics #130236
unstable feature usage metrics #130236
Conversation
This comment has been minimized.
This comment has been minimized.
25ee72d
to
06b95b2
Compare
This comment has been minimized.
This comment has been minimized.
06b95b2
to
29fcb25
Compare
This comment has been minimized.
This comment has been minimized.
29fcb25
to
28d9d1b
Compare
This comment has been minimized.
This comment has been minimized.
r? @estebank |
28d9d1b
to
3addcf4
Compare
This comment has been minimized.
This comment has been minimized.
9ca273b
to
cd70825
Compare
This comment has been minimized.
This comment has been minimized.
cd70825
to
137db8d
Compare
This comment has been minimized.
This comment has been minimized.
b0fcb24
to
3cf1bb8
Compare
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. This PR modifies cc @jieyouxu |
3cf1bb8
to
35bfeff
Compare
This comment has been minimized.
This comment has been minimized.
35bfeff
to
5d8de54
Compare
This comment has been minimized.
This comment has been minimized.
5d8de54
to
9dd032f
Compare
This comment has been minimized.
This comment has been minimized.
9dd032f
to
5a05655
Compare
This comment has been minimized.
This comment has been minimized.
5a05655
to
609925f
Compare
609925f
to
dc97db1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
.arg("-Zmetrics-dir=invaliddirectorythatdefinitelydoesntexist") | ||
.run_fail() | ||
.assert_stderr_contains( | ||
"error: cannot dump feature usage metrics: No such file or directory", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we use dyn Error
/IOError
we don't display the file path that we couldn't open. That's not ideal but ok for now. Let's revisit in the future.
Co-authored-by: Esteban Kuber <[email protected]>
@bors r=estebank |
@bors r+ |
@bors r=estebank |
β¦iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#130236 (unstable feature usage metrics) - rust-lang#131544 (Make asm label blocks safe context) - rust-lang#131586 (Support s390x z13 vector ABI) - rust-lang#132489 (Fix closure arg extraction in `extract_callable_info`, generalize it to async closures) - rust-lang#133078 (tests: ui/inline-consts: add issue number to a test, rename other tests) - rust-lang#133283 (Don't exclude relnotes from `needs-triage` label) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130236 - yaahc:unstable-feature-usage, r=estebank unstable feature usage metrics example output ``` test-lib on ξ master [?] is π¦ v0.1.0 via π¦ v1.80.1 β― cat src/lib.rs ββββββββ¬βββββββββββββββββββββββββββββββββββββββββββββββββββββββ β File: src/lib.rs ββββββββΌβββββββββββββββββββββββββββββββββββββββββββββββββββββββ 1 β #![feature(unix_set_mark)] 2 β pub fn add(left: u64, right: u64) -> u64 { 3 β left + right 4 β } 5 β 6 β #[cfg(test)] 7 β mod tests { 8 β use super::*; 9 β 10 β #[test] 11 β fn it_works() { 12 β let result = add(2, 2); 13 β assert_eq!(result, 4); 14 β } 15 β } ββββββββ΄βββββββββββββββββββββββββββββββββββββββββββββββββββββββ test-lib on ξ master [?] is π¦ v0.1.0 via π¦ v1.80.1 β― cargo +stage1 rustc -- -Zmetrics-dir=$PWD/metrics Compiling test-lib v0.1.0 (/home/yaahc/tmp/test-lib) Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s test-lib on ξ master [?] is π¦ v0.1.0 via π¦ v1.80.1 β― cat metrics/unstable_feature_usage.json ββββββββ¬βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ β File: metrics/unstable_feature_usage.json ββββββββΌβββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ 1 β {"lib_features":[{"symbol":"unix_set_mark"}],"lang_features":[]} ``` related to rust-lang#129485
example output
related to #129485