Move elided_named_lifetimes into a separate pass
#130150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
cjgillot
reviewed
Sep 9, 2024
cjgillot
reviewed
Sep 9, 2024
GrigorenkoPV
force-pushed
the
elided-named-lifetimes-pass
branch
from
9174d9f
to
be8f80a
Compare
This comment has been minimized.
This comment has been minimized.
GrigorenkoPV
force-pushed
the
elided-named-lifetimes-pass
branch
from
be8f80a
to
4d638bd
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
I'm not sure if it is possible to fix those false negatives at all with this approach |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☔ The latest upstream changes (presumably #107251) made this pull request unmergeable. Please resolve the merge conflicts. |
cjgillot
reviewed
Sep 14, 2024
Comment on lines
+51
to
+76
| fn check_trait_item(&mut self, _: &LateContext<'tcx>, item: &'tcx TraitItem<'tcx>) { | ||
| if let TraitItemKind::Const(..) = item.kind { | ||
| self.allow_static = true; | ||
| } | ||
| } | ||
| fn check_trait_item_post(&mut self, _: &LateContext<'tcx>, _: &'tcx TraitItem<'tcx>) { | ||
| self.allow_static = false; | ||
| } | ||
|
|
||
| fn check_impl_item(&mut self, _: &LateContext<'tcx>, item: &'tcx ImplItem<'tcx>) { | ||
| if let ImplItemKind::Const(..) = item.kind { | ||
| self.allow_static = true; | ||
| } | ||
| } | ||
| fn check_impl_item_post(&mut self, _: &LateContext<'tcx>, _: &'tcx ImplItem<'tcx>) { | ||
| self.allow_static = false; | ||
| } | ||
|
|
||
| fn check_item(&mut self, _: &LateContext<'tcx>, item: &'tcx Item<'tcx>) { | ||
| if let ItemKind::Const(..) | ItemKind::Static(..) = item.kind { | ||
| self.allow_static = true; | ||
| } | ||
| } | ||
| fn check_item_post(&mut self, _: &LateContext<'tcx>, _: &'tcx Item<'tcx>) { | ||
| self.allow_static = false; | ||
| } |
There was a problem hiding this comment.
I'm not convinced this handles cases like:
const FOO: ConstGeneric<{
const BAR: usize = 5;
BAR
}, &u8> = /* */;
You may need an actual stack.
There was a problem hiding this comment.
I think just storing the id of the outermost item would be enough.
However, I am reluctant to move any further with this PR as I suspect some lifetimes, which are present in AST, are not present in HIR and thus are unlintable with this approach.
cjgillot
added
S-waiting-on-author
|
@GrigorenkoPV |
I am reluctant to move forward with it, since some lifetimes (which appear in AST, where this lint would previously run) seem to be not preserved after the translation to HIR, where the lint would run after this PR. You can see those changes in the tests' diff. IMO, the places where the lifetimes disappear are one of the most valuable ones as they involve pretty complex signatures with The main reason for this PR was to move In any case, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @cjgillot
Trying to move forward with #129840 (comment)
Current results, from sad to happy:
ElidedNamedLifetimediagnostic decorator can almost be moved from a hand-rolled impl to a derived one. (Is that a good thing?) The only problem seems to be that you can't slap both#[label]&#[primary_span]on the same field.ElidedNamedLifetimespass. Yay.LateLintPassnow hascheck_trait_item_post&check_lifetime.MissingLifetime.id_for_lint& theLifetimeRes::Static.suppress_elision_warninghacks got removed.