Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Mv OsStr/OsStrExt/Path to core, OsString/OsStringExt/PathBuf to alloc #129411

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Aug 22, 2024

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 22, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Aug 23, 2024

☔ The latest upstream changes (presumably #129443) made this pull request unmergeable. Please resolve the merge conflicts.

@NobodyXu NobodyXu force-pushed the move/os-str branch 4 times, most recently from 43db21c to 3317d1b Compare August 25, 2024 14:53
@workingjubilee
Copy link
Member

Thanks so much for working on this, this is going to make working on backtrace so much more tolerable.

@@ -89,3 +89,18 @@ pub use self::c_str::{FromVecWithNulError, IntoStringError, NulError};

#[unstable(feature = "c_str_module", issue = "112134")]
pub mod c_str;

#[stable(feature = "rust1", since = "1.0.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably only the re-exports in libstd should have these, and the alloc/core originals should be marked unstable for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've marked them as unstable for now.

Someone else interested in it could stablise it.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@NobodyXu NobodyXu changed the title Refactor: Mv OsStr/OsStrExt to core, OsString/OsStringExt to alloc Refactor: Mv OsStr/OsStrExt/Path to core, OsString/OsStringExt to alloc Aug 27, 2024
@rust-log-analyzer

This comment has been minimized.

@NobodyXu NobodyXu changed the title Refactor: Mv OsStr/OsStrExt/Path to core, OsString/OsStringExt to alloc Refactor: Mv OsStr/OsStrExt/Path to core, OsString/OsStringExt/PathBuf to alloc Aug 27, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Sep 2, 2024

☔ The latest upstream changes (presumably #129063) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#16 2.851 Building wheels for collected packages: reuse
#16 2.852   Building wheel for reuse (pyproject.toml): started
#16 3.092   Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.093   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132715 sha256=dfa09868353292d98f811d3efdb0d54d07389e808efc71d68e3b93c514bf8bec
#16 3.093   Stored in directory: /tmp/pip-ephem-wheel-cache-hnbdbu5_/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.096 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.494 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.494 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.6s

@bors
Copy link
Contributor

bors commented Sep 4, 2024

☔ The latest upstream changes (presumably #129962) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants