Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #129349

Closed
wants to merge 19 commits into from
Closed

Commits on Jul 21, 2022

  1. Configuration menu
    Copy the full SHA
    01b68b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Special case DUMMY_SP to emit line 0/column 0 locations on DWARF plat…

    …forms.
    
    Line 0 has a special meaning in DWARF. From the version 5 spec:
    
        The compiler may emit the value 0 in cases
        where an instruction cannot be attributed to any
        source line.
    
    DUMMY_SP spans cannot be attributed to any line. However, because rustc
    internally stores line numbers starting at zero, lookup_debug_loc() adjusts
    every line number by one. Special casing DUMMY_SP to actually emit line 0
    ensures rustc communicates to the debugger that there's no meaningful source
    code for this instruction, rather than telling the debugger to jump to line 1
    randomly.
    khuey committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    78caecf View commit details
    Browse the repository at this point in the history
  2. Use Span::is_dummy().

    khuey committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    e587855 View commit details
    Browse the repository at this point in the history
  3. Fix warning.

    khuey committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    5dc4a19 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. bootstrap: fix clean's remove_dir_all implementation

    ... by using `std::fs::remove_dir_all`, which handles a bunch of edge
    cases including read-only files and symlinks which are extremely tricky
    on Windows.
    jieyouxu committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    1687c55 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Update library/Cargo.toml in weekly job

    Before the workspace split, the library was covered by the weekly `cargo
    update` cron job. Now that the library has its own workspace, it doesn't
    get these updates.
    
    Add `library/Cargo.toml` to the job so updates happen again.
    tgross35 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    35752cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76fbf0a View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Add a test.

    khuey committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3c735a0 View commit details
    Browse the repository at this point in the history
  2. Add a comment.

    khuey committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4e9725c View commit details
    Browse the repository at this point in the history
  3. rustdoc: animate the :target highlight

    This approach is, roughly, based on how Discourse does it.
    It came up while discussing some other possible sidebar changes,
    as a design that made rapid scanning easier while avoiding the
    inherent trade-offs in summarizing.
    notriddle committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9d7574f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    40af214 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    0f5c6ea View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#97524 - ibraheemdev:thread-raw, r=joshtriplett

    Add `Thread::{into_raw, from_raw}`
    
    Public API:
    ```rust
    #![unstable(feature = "thread_raw", issue = "97523")]
    
    impl Thread {
        pub fn into_raw(self) -> *const ();
        pub unsafe fn from_raw(ptr: *const ()) -> Thread;
    }
    ```
    
    ACP: rust-lang/libs-team#200
    tgross35 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0d7075e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#128627 - khuey:DUMMY_SP-line-no, r=nnethercote

    Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms.
    
    Line 0 has a special meaning in DWARF. From the version 5 spec:
    
        The compiler may emit the value 0 in cases
        where an instruction cannot be attributed to any
        source line.
    
    DUMMY_SP spans cannot be attributed to any line. However, because rustc internally stores line numbers starting at zero, lookup_debug_loc() adjusts every line number by one. Special casing DUMMY_SP to actually emit line 0 ensures rustc communicates to the debugger that there's no meaningful source code for this instruction, rather than telling the debugger to jump to line 1 randomly.
    tgross35 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ce9675b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#129187 - jieyouxu:squeaky-clean-windows-sym…

    …links, r=Kobzol
    
    bootstrap: fix clean's remove_dir_all implementation
    
    It turns out bootstrap's `clean.rs`'s hand-rolled `rm_rf` (which probably comes before `std::fs::remove_dir_all` was stable) is very broken on native Windows around both read-only files/directories and especially symbolic links. So instead of rolling our own, just use `std::fs::remove_dir_all`.
    
    This is a blocker for compiletest's own `rm_rf` implementation rust-lang#129155 which happens to be also buggy, which in turn is a blocker for the rmake.rs test port rust-lang#128562 that heavily exercises symlinks (I was reviewing rust-lang#128562 and testing it on native Windows which is how I found out).
    
    I also left a FIXME for `detect_src_and_out` due to a failing assertion on native Windows (opened rust-lang#129188):
    
    ```
    ---- core::config::tests::detect_src_and_out stdout ----
    thread 'core::config::tests::detect_src_and_out' panicked at src\core\config\tests.rs:72:13:
    assertion `left == right` failed
      left: "E:\\tmp"
     right: "C:\\tmp"
    ```
    
    Fixes rust-lang#112544 (because now we handle Windows symlinks properly).
    
    try-job: x86_64-msvc
    try-job: i686-mingw
    try-job: test-various
    try-job: armhf-gnu
    try-job: aarch64-apple
    try-job: aarch64-gnu
    tgross35 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f9fc459 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#129257 - ChrisDenton:rename-null-descriptor…

    …, r=jieyouxu
    
    Allow rust staticlib to work with MSVC's /WHOLEARCHIVE
    
    This fixes rust-lang#129020 by renaming the `__NULL_IMPORT_DESCRIPTOR` to prevent conflicts.
    
    try-job: dist-i686-msvc
    tgross35 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    58c7f92 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#129264 - tgross35:dependencies-ci-library, …

    …r=Kobzol
    
    Update `library/Cargo.toml` in weekly job
    
    Before the workspace split, the library was covered by the weekly `cargo update` cron job. Now that the library has its own workspace, it doesn't get these updates.
    
    Add `library/Cargo.toml` to the job so updates happen again.
    tgross35 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d1a279e View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#129284 - notriddle:notriddle/animate-target…

    …=light, r=GuillaumeGomez
    
    rustdoc: animate the `:target` highlight
    
    This approach is, roughly, based on how Discourse does it. It came up while discussing [some other possible sidebar changes](https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/Moving.20deprecated.20items.20out.20of.20the.20way), as a design that made rapid scanning easier while avoiding the inherent trade-offs in summarizing.
    
    https://github.com/user-attachments/assets/f7a8fec3-70a5-40a1-92ea-bfdffbd61c22
    tgross35 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    763509b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#129339 - beetrees:make-indirect-from-ignore…

    …, r=RalfJung
    
    Make `ArgAbi::make_indirect_force` more specific
    
    As the method is only needed for making ignored ZSTs indirect on some ABIs, rename and add a doc-comment and `self.mode` check to make it harder to accidentally misuse. Addresses review feedback from rust-lang#125854 (comment).
    
    r? `@RalfJung`
    tgross35 authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e5480f8 View commit details
    Browse the repository at this point in the history