bootstrap: improve error recovery flags to curl #129134

lolbinarycat · 2024-08-15T20:32:48Z

alternative to #128459

rustbot · 2024-08-15T20:32:56Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kobzol (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

alternative to rust-lang#128459 fixes rust-lang#110178

Kobzol

Thanks, this seems like a much less invasive change! Left some comments.

src/bootstrap/bootstrap.py

src/bootstrap/src/core/download.rs

Kobzol · 2024-08-24T19:47:59Z

Btw, you can run ./x test tidy to run the fast CI check that is performed after each push to a PR. And ./x fmt to reformat code.

lolbinarycat · 2024-08-24T20:38:49Z

I know, but tidy takes an eternity to run on a hdd system.

lolbinarycat · 2024-08-24T20:44:17Z

i think there's actually a bug in get_git_modified_files, actually, it's reporting a number that way too high. probably because the current branch is actually behind the local master branch, since i haven't rebased it since the last git pull.

lolbinarycat · 2024-08-24T21:27:50Z

i think there's actually a bug in get_git_modified_files, actually, it's reporting a number that way too high. probably because the current branch is actually behind the local master branch, since i haven't rebased it since the last git pull.

not a bug, just extremely bad ux. see #129528

Kobzol · 2024-08-24T21:44:47Z

Thanks! You can r=me once PR CI is green.

@bors delegate+

bors · 2024-08-24T21:44:50Z

✌️ @lolbinarycat, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

lolbinarycat · 2024-08-25T00:38:27Z

@bors r=@Kobzol

bors · 2024-08-25T00:38:30Z

📌 Commit 56adf87 has been approved by Kobzol

It is now in the queue for this repository.

bootstrap: improve error recovery flags to curl alternative to rust-lang#128459 fixes rust-lang#110178 r? `@Kobzol`

Rollup of 8 pull requests Successful merges: - rust-lang#126985 (Implement `-Z embed-source` (DWARFv5 source code embedding extension)) - rust-lang#128935 (More work on `zstd` compression) - rust-lang#129134 (bootstrap: improve error recovery flags to curl) - rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs) - rust-lang#129416 (library: Move unstable API of new_uninit to new features) - rust-lang#129418 (rustc: Simplify getting sysroot library directory) - rust-lang#129459 (handle stage0 `cargo` and `rustc` separately) - rust-lang#129511 (Update minifier to 0.3.1) r? `@ghost` `@rustbot` modify labels: rollup

bootstrap: improve error recovery flags to curl alternative to rust-lang#128459 fixes rust-lang#110178 r? ``@Kobzol``

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#128919 (Add an internal lint that warns when accessing untracked data) - rust-lang#129134 (bootstrap: improve error recovery flags to curl) - rust-lang#129416 (library: Move unstable API of new_uninit to new features) - rust-lang#129459 (handle stage0 `cargo` and `rustc` separately) - rust-lang#129487 (repr_transparent_external_private_fields: special-case some std types) - rust-lang#129511 (Update minifier to 0.3.1) - rust-lang#129523 (Make `rustc_type_ir` build on stable) - rust-lang#129546 (Get rid of `predicates_defined_on`) r? `@ghost` `@rustbot` modify labels: rollup

bootstrap: improve error recovery flags to curl alternative to rust-lang#128459 fixes rust-lang#110178 r? ```@Kobzol```

also fixes a discrepency where the rust side doesn't use -L must not be merged before rust-lang#129134 docs are only on the rust side, since duplicated prose has a tendancy to get out-of-sync, and also because there are talks of removing the python script all together eventually.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129091 (add Box::as_ptr and Box::as_mut_ptr methods) - rust-lang#129134 (bootstrap: improve error recovery flags to curl) - rust-lang#129416 (library: Move unstable API of new_uninit to new features) - rust-lang#129459 (handle stage0 `cargo` and `rustc` separately) - rust-lang#129487 (repr_transparent_external_private_fields: special-case some std types) - rust-lang#129511 (Update minifier to 0.3.1) - rust-lang#129523 (Make `rustc_type_ir` build on stable) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129134 - lolbinarycat:continue-at, r=Kobzol bootstrap: improve error recovery flags to curl alternative to rust-lang#128459 fixes rust-lang#110178 r? ````@Kobzol````

rustbot assigned Kobzol Aug 15, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 15, 2024