[beta] backports and bump stage0 #129033
Merged
[beta] backports and bump stage0 #129033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jump threading stores values as `u128` (`ScalarInt`) and does its comparisons for equality as integer comparisons. This works great for integers. Sadly, not everything is an integer. Floats famously have wonky equality semantcs, with `NaN!=NaN` and `0.0 == -0.0`. This does not match our beautiful integer bitpattern equality and therefore causes things to go horribly wrong. While jump threading could be extended to support floats by remembering that they're floats in the value state and handling them properly, it's signficantly easier to just disable it for now. (cherry picked from commit f305e18)
(cherry picked from commit c6f8672)
The new sort implementations have the ability to detect Ord violations in many cases. This commit improves the message in a way that should help users realize what went wrong in their program. (cherry picked from commit 644550f)
…ble* - Move panic information into # Panics section - Fix mentions of T: Ord that should be compare - Add missing information (cherry picked from commit 00ce238)
- Use if the implementation of [`Ord`] for `T` language - Link to total order wiki page - Rework total order help and examples - Improve language to be more precise and less prone to misunderstandings. - Fix usage of `sort_unstable_by` in `sort_by` example - Fix missing author mention - Use more consistent example input for sort - Use more idiomatic assert_eq! in examples - Use more natural "comparison function" language instead of "comparator function" (cherry picked from commit afc404f)
(cherry picked from commit eae7a18)
(cherry picked from commit 613155c)
(cherry picked from commit 1be60b5)
|
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
(cherry picked from commit 5534cb0)
The special case was failing to handle invisible delimiters on one path. Fixes rust-lang#128895. (cherry picked from commit 46b4c5a)
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dyntails in MIR borrowck Normalize when equatingdyntails in MIR borrowck #128694Ordviolation help ImproveOrdviolation help #128273hir::ConstArg#125915 on beta Revert #125915 on beta #128760Parser::look_ahead. Fix bug inParser::look_ahead. #128994r? cuviper