Migrate jobserver-error run-make test to rmake
#128789
Open
+96
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
untestioned-devotion
branch
from
484fa0e to
97091f2
Compare
Oneirical
force-pushed
the
untestioned-devotion
branch
from
77c21c5 to
6b3c4c2
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
untestioned-devotion
branch
from
6b3c4c2 to
8816029
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
untestioned-devotion
branch
from
8816029 to
6f67fa0
Compare
Oneirical
force-pushed
the
untestioned-devotion
branch
from
6f67fa0 to
482fa51
Compare
|
This PR modifies cc @jieyouxu The run-make-support library was changed cc @jieyouxu |
|
☔ The latest upstream changes (presumably #131917) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876 and the associated Google Summer of Code project.
In a similar fashion to #128460, this test contains peculiar interactions with the
/dev/directory and piping to file descriptors. Note the massive commented section, which requires figuring out how to pipe/dev/null/to file descriptor3to get this to work.Will need try jobs, but not yet.