-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coalesce dep-info
, dep-info-spaces
and dep-info-doesnt-run-much
run-make
tests into dep-info
rmake.rs
#128787
Conversation
This PR modifies cc @jieyouxu |
tests/run-make/dep-info/rmake.rs
Outdated
// FIXME try it on windows and freebsd | ||
// on windows `rustc --dep-info` produces Makefile dependency with | ||
// windows native paths (e.g. `c:\path\to\libfoo.a`) | ||
// but msys make seems to fail to recognize such paths, so test fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors try |
…=<try> Coalesce `dep-info`, `dep-info-spaces` and `dep-info-doesnt-run-much` `run-make` tests into `dep-info` rmake.rs Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This is one of the most ancient tests in the `run-make` directory and its Makefile does some unexpected things, like creating and deleting a `done` directory over and over, sleeping at certain times (this is the [commit](rust-lang@0d9fd8e) that added the `sleep`). I tried to preserve the intent of the test, which is smoke-testing that `dep-info` works. Try: try-job: x86_64-msvc try-job: i686-mingw try-job: dist-x86_64-freebsd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I clicked wrong button
☀️ Try build successful - checks-actions |
b54ae7e
to
7b18186
Compare
I'm not sure if you want me to change something in particular. I removed the ignore statement, since the try job passed. @rustbot review |
@@ -0,0 +1,36 @@ | |||
// This is a simple smoke test for rustc's `--emit dep-info` feature. It prints out | |||
// information about dependencies in a Makefile-compatible format, as a `.d` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: we should make it clear that we don't attempt to check the .d
file is in fact Makefile-compatible in this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustbot author
@bors try |
Feel free to r=me after clarifying the comment and if try jobs come back green. |
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
@bors rollup=iffy (dep info) |
…=<try> Coalesce `dep-info`, `dep-info-spaces` and `dep-info-doesnt-run-much` `run-make` tests into `dep-info` rmake.rs Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This is one of the most ancient tests in the `run-make` directory and its Makefile does some unexpected things, like creating and deleting a `done` directory over and over, sleeping at certain times (this is the [commit](rust-lang@0d9fd8e) that added the `sleep`). I tried to preserve the intent of the test, which is smoke-testing that `dep-info` works. try-job: x86_64-msvc try-job: i686-mingw try-job: aarch64-gnu try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: dist-various-1
…=<try> Coalesce `dep-info`, `dep-info-spaces` and `dep-info-doesnt-run-much` `run-make` tests into `dep-info` rmake.rs Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This is one of the most ancient tests in the `run-make` directory and its Makefile does some unexpected things, like creating and deleting a `done` directory over and over, sleeping at certain times (this is the [commit](rust-lang@0d9fd8e) that added the `sleep`). I tried to preserve the intent of the test, which is smoke-testing that `dep-info` works. try-job: x86_64-msvc try-job: i686-mingw try-job: aarch64-gnu try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: dist-various-1
bors go home you're drunk |
☀️ Try build successful - checks-actions |
7b18186
to
7c4d561
Compare
… r=jieyouxu Coalesce `dep-info`, `dep-info-spaces` and `dep-info-doesnt-run-much` `run-make` tests into `dep-info` rmake.rs Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This is one of the most ancient tests in the `run-make` directory and its Makefile does some unexpected things, like creating and deleting a `done` directory over and over, sleeping at certain times (this is the [commit](rust-lang@0d9fd8e) that added the `sleep`). I tried to preserve the intent of the test, which is smoke-testing that `dep-info` works. try-job: x86_64-msvc try-job: i686-mingw try-job: aarch64-gnu try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: dist-various-1
☀️ Test successful - checks-actions |
Finished benchmarking commit (4b7d074): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.1%, secondary -1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.842s -> 750.562s (-0.17%) |
Part of #121876 and the associated Google Summer of Code project.
This is one of the most ancient tests in the
run-make
directory and its Makefile does some unexpected things, like creating and deleting adone
directory over and over, sleeping at certain times (this is the commit that added thesleep
).I tried to preserve the intent of the test, which is smoke-testing that
dep-info
works.try-job: x86_64-msvc
try-job: i686-mingw
try-job: aarch64-gnu
try-job: aarch64-apple
try-job: test-various
try-job: armhf-gnu
try-job: dist-various-1