Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #128773

Closed
wants to merge 33 commits into from
Closed

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 7, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

dheaton-arm and others added 30 commits July 30, 2024 10:12
Added run-make tests to verify that, between a Rust-C FFI boundary in both directions,
any MTE tags included in a pointer are preserved for the following pointer types, as
well as any information stored using TBI:
- int
- float
- string
- function
Version 0.3.1 has added support for writing import libraries. Version
0.3.2 fixed creating archives containing members of import libraries.
This is simply a matter of using the right argument for lld-link.
This includes [1] which means we can remove the (nonworking)
configuration of `no-f16-f128`.

Fixes rust-lang#128401.

[1]: rust-lang/compiler-builtins#652
Co-authored-by: Amanieu d'Antras <[email protected]>
…, r=jieyouxu

Make create_dll_import_lib easier to implement

This will make it easier to implement raw-dylib support in cg_clif and cg_gcc. This PR doesn't yet include an create_dll_import_lib implementation for cg_clif as I need to correctly implement dllimport in cg_clif first before raw-dylib can work at all with cg_clif.

Required for rust-lang/rustc_codegen_cranelift#1345
…res, r=Amanieu

Add implied target features to target_feature attribute

See [zulip](https://rust-lang.zulipchat.com/#narrow/stream/208962-t-libs.2Fstdarch/topic/Why.20would.20target-feature.20include.20implied.20features.3F) for some context.  Adds implied target features, e.g. `#[target_feature(enable = "avx2")]` acts like `#[target_feature(enable = "avx2,avx,sse4.2,sse4.1...")]`.  Fixes rust-lang#128125, fixes rust-lang#128426

The implied feature sets are taken from [the rust reference](https://doc.rust-lang.org/reference/attributes/codegen.html?highlight=target-fea#x86-or-x86_64), there are certainly more features and targets to add.

Please feel free to reassign this to whoever should review it.

r? `@Amanieu`
Add tests to ensure MTE tags are preserved across FFI boundaries

Added run-make tests to verify that, between a Rust-C FFI boundary in both directions, any MTE tags included in a pointer are preserved for the following pointer types, as well as any information stored using TBI:
- int
- float
- string
- function

try-job: aarch64-gnu
Enable msvc for run-make/rust-lld

This is simply a matter of using the right argument for lld-link.

As a bonus, I also fixed a typo.

try-job: i686-msvc
try-job: x86_64-msvc
Update `compiler-builtins` to 0.1.117

This includes [1] which means we can remove the (nonworking) configuration of `no-f16-f128`.

Fixes rust-lang#128401.

[1]: rust-lang/compiler-builtins#652

try-job: dist-various-1
…e-simdple, r=jieyouxu

Migrate `simd-ffi` `run-make` test to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-17
…ross35

Specify a minimum supported version for VxWorks

Document that VxWorks 7 is the minimum supported version.
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 7, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 7, 2024

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Aug 7, 2024

📌 Commit a1e70ad has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#128206 (Make create_dll_import_lib easier to implement)
 - rust-lang#128221 (Add implied target features to target_feature attribute)
 - rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries)
 - rust-lang#128656 (Enable msvc for run-make/rust-lld)
 - rust-lang#128691 (Update `compiler-builtins` to 0.1.117)
 - rust-lang#128700 (Migrate `simd-ffi` `run-make` test to rmake)
 - rust-lang#128758 (Specify a minimum supported version for VxWorks)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Aug 7, 2024

⌛ Testing commit a1e70ad with merge 48280ea...

@rust-log-analyzer
Copy link
Collaborator

The job dist-powerpc64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling ar_archive_writer v0.3.2
error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:52:36
    |
52  |     let is_ec = header.machine.get(object::NativeEndian) == object::pe::IMAGE_FILE_MACHINE_ARM64EC;
    |                                --- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    |                                arguments to this method are incorrect
    |
note: method defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:634:12
   --> /rust/deps/object-0.36.2/src/endian.rs:634:12
    |
634 |     pub fn get(self, e: E) -> u16 {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:80:27
    |
    |
80  |     if header.machine.get(object::NativeEndian) == object::pe::IMAGE_FILE_MACHINE_ARM64EC {
    |                       --- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    |                       arguments to this method are incorrect
    |
note: method defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:634:12
   --> /rust/deps/object-0.36.2/src/endian.rs:634:12
    |
634 |     pub fn get(self, e: E) -> u16 {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:34:26
    |
    |
32  | / macro_rules! u16 {
33  | |     ($val:expr) => {
34  | |         object::U16::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
35  | |     };
36  | | }
    | |_- in this expansion of `u16!`
    | |_- in this expansion of `u16!`
...
131 | /     u16!(match machine {
132 | |         MachineTypes::AMD64 => IMAGE_REL_AMD64_ADDR32NB,
133 | |         MachineTypes::ARMNT => IMAGE_REL_ARM_ADDR32NB,
134 | |         MachineTypes::ARM64 | MachineTypes::ARM64EC | MachineTypes::ARM64X =>
135 | |             IMAGE_REL_ARM64_ADDR32NB,
136 | |         MachineTypes::I386 => IMAGE_REL_I386_DIR32NB,
    | |______- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
    |
629 |     pub fn new(e: E, n: u16) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:34:26
    |
    |
32  | / macro_rules! u16 {
33  | |     ($val:expr) => {
34  | |         object::U16::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
35  | |     };
36  | | }
    | |_- in this expansion of `u16!`
    | |_- in this expansion of `u16!`
...
261 |               machine: u16!(self.native_machine.into()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
    |
    |
629 |     pub fn new(e: E, n: u16) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:34:26
    |
    |
32  | / macro_rules! u16 {
33  | |     ($val:expr) => {
34  | |         object::U16::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
35  | |     };
36  | | }
    | |_- in this expansion of `u16!`
    | |_- in this expansion of `u16!`
...
262 |               number_of_sections: u16!(NUMBER_OF_SECTIONS.try_into().unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
    |
    |
629 |     pub fn new(e: E, n: u16) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
263 |               time_date_stamp: u32!(0),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
264 |               pointer_to_symbol_table: u32!((size_of::<ImageFileHeader>() + (NUMBER_OF_SECTIONS * size_of::<ImageSectionHeader>()) +
265 | |                 // .idata$2
265 | |                 // .idata$2
266 | |                 size_of::<ImageImportDescriptor>() +
267 | |                 NUMBER_OF_RELOCATIONS * size_of::<ImageRelocation>() +
268 | |                 // .idata$4
269 | |                 (self.import_name.len() + 1)).try_into().unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
270 |               number_of_symbols: u32!(NUMBER_OF_SYMBOLS.try_into().unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:34:26
    |
    |
32  | / macro_rules! u16 {
33  | |     ($val:expr) => {
34  | |         object::U16::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
35  | |     };
36  | | }
    | |_- in this expansion of `u16!`
    | |_- in this expansion of `u16!`
...
271 |               size_of_optional_header: u16!(0),
    |                                        ------- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
    |
629 |     pub fn new(e: E, n: u16) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:34:26
    |
    |
32  | / macro_rules! u16 {
33  | |     ($val:expr) => {
34  | |         object::U16::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
35  | |     };
36  | | }
    | |_- in this expansion of `u16!`
    | |_- in this expansion of `u16!`
...
272 |               characteristics: u16!(if self.is_64_bit() {
273 | |                 0
274 | |             } else {
275 | |                 IMAGE_FILE_32BIT_MACHINE
276 | |             }),
276 | |             }),
    | |______________- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
    |
629 |     pub fn new(e: E, n: u16) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
284 |                   virtual_size: u32!(0),
    |                                 ------- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
285 |                   virtual_address: u32!(0),
    |                                    ------- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
286 |                   size_of_raw_data: u32!(size_of::<ImageImportDescriptor>().try_into().unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
287 |                   pointer_to_raw_data: u32!((size_of::<ImageFileHeader>()
    |  ______________________________________-
288 | |                     + NUMBER_OF_SECTIONS * size_of::<ImageSectionHeader>())
289 | |                 .try_into()
290 | |                 .unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
291 |                   pointer_to_relocations: u32!((size_of::<ImageFileHeader>()
    |  _________________________________________-
292 | |                     + NUMBER_OF_SECTIONS * size_of::<ImageSectionHeader>()
293 | |                     + size_of::<ImageImportDescriptor>())
294 | |                 .try_into()
295 | |                 .unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
296 |                   pointer_to_linenumbers: u32!(0),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:34:26
    |
    |
32  | / macro_rules! u16 {
33  | |     ($val:expr) => {
34  | |         object::U16::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
35  | |     };
36  | | }
    | |_- in this expansion of `u16!`
    | |_- in this expansion of `u16!`
...
297 |                   number_of_relocations: u16!(NUMBER_OF_RELOCATIONS.try_into().unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
    |
    |
629 |     pub fn new(e: E, n: u16) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:34:26
    |
    |
32  | / macro_rules! u16 {
33  | |     ($val:expr) => {
34  | |         object::U16::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
35  | |     };
36  | | }
    | |_- in this expansion of `u16!`
    | |_- in this expansion of `u16!`
...
298 |                   number_of_linenumbers: u16!(0),
    |                                          ------- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:629:12
    |
629 |     pub fn new(e: E, n: u16) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
299 |                   characteristics: u32!(
    |  __________________________________-
300 | |                     IMAGE_SCN_ALIGN_4BYTES
301 | |                         | IMAGE_SCN_CNT_INITIALIZED_DATA
302 | |                         | IMAGE_SCN_MEM_READ
303 | |                         | IMAGE_SCN_MEM_WRITE
    | |_________________- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
308 |                   virtual_size: u32!(0),
    |                                 ------- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
309 |                   virtual_address: u32!(0),
    |                                    ------- in this macro invocation
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
656 |     pub fn new(e: E, n: u32) -> Self {

error[E0308]: mismatched types
   --> /rust/deps/ar_archive_writer-0.3.2/src/coff_import_file.rs:40:26
    |
    |
38  | / macro_rules! u32 {
39  | |     ($val:expr) => {
40  | |         object::U32::new(object::NativeEndian, $val)
    | |         ---------------- ^^^^^^^^^^^^^^^^^^^^ expected `LittleEndian`, found `BigEndian`
    | |         arguments to this function are incorrect
41  | |     };
42  | | }
    | |_- in this expansion of `u32!`
    | |_- in this expansion of `u32!`
...
310 |                   size_of_raw_data: u32!((self.import_name.len() + 1).try_into().unwrap()),
    |
note: associated function defined here
   --> /rust/deps/object-0.36.2/src/endian.rs:656:12
    |
    |
656 |     pub fn new(e: E, n: u32) -> Self {

@bors
Copy link
Contributor

bors commented Aug 7, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 7, 2024
@tgross35 tgross35 closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants