Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make import.vis is immutable #128732

Merged
merged 1 commit into from
Aug 7, 2024
Merged

make import.vis is immutable #128732

merged 1 commit into from
Aug 7, 2024

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Aug 6, 2024

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2024
@bvanjoi bvanjoi changed the title make import.vis is not mutable make import.vis is immutable Aug 6, 2024
petrochenkov
petrochenkov reviewed Aug 6, 2024
View reviewed changes
compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/ident.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/ident.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/macros.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/build_reduced_graph.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/ident.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/ident.rs Outdated Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

So I wondered if it's possible to have multiple ignored imports at the same time, but it looks like it's not possible.
vis.take() was only called from resolve_import and finalize_import which are "top level" functions never called while resolving other imports.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2024
@bvanjoi bvanjoi force-pushed the immutable-import-vis branch from 533a279 to 683fc7e Compare August 7, 2024 11:54
@petrochenkov
Copy link
Contributor

r=me with #128732 (comment) addressed.
@bors delegate+

@bors
Copy link
Contributor

bors commented Aug 7, 2024

✌️ @bvanjoi, you can now approve this pull request!

If @petrochenkov told you to "r=me" after making some further change, please make that change, then do @bors r=@petrochenkov

@bvanjoi bvanjoi force-pushed the immutable-import-vis branch from 683fc7e to fa96173 Compare August 7, 2024 13:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bvanjoi bvanjoi force-pushed the immutable-import-vis branch from fa96173 to 8c06dc4 Compare August 7, 2024 14:13
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Aug 7, 2024

ci is green

@bors r=@petrochenkov

@bors
Copy link
Contributor

bors commented Aug 7, 2024

📌 Commit 8c06dc4 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
@bors
Auto merge of rust-lang#128796 - matthiaskrgr:rollup-r7l68ph, r=matth…
8b38707 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128221 (Add implied target features to target_feature attribute)
 - rust-lang#128261 (impl `Default` for collection iterators that don't already have it)
 - rust-lang#128353 (Change generate-copyright to generate HTML, with cargo dependencies included)
 - rust-lang#128679 (codegen: better centralize function declaration attribute computation)
 - rust-lang#128732 (make `import.vis` is immutable)
 - rust-lang#128755 (Integrate crlf directly into related test file instead via of .gitattributes)
 - rust-lang#128772 (rustc_codegen_ssa: Set architecture for object crate for 32-bit SPARC)
 - rust-lang#128782 (unused_parens: do not lint against parens around &raw)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8f5b50d into rust-lang:master Aug 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
@rust-timer
Unrolled build for rust-lang#128732
f2b3180 
Rollup merge of rust-lang#128732 - bvanjoi:immutable-import-vis, r=petrochenkov

make `import.vis` is immutable

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bvanjoi @petrochenkov @bors @rust-log-analyzer @rustbot