Add Debug impls to API types in rustc_codegen_ssa
#128664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jubilee <[email protected]>
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128385 (rustdoc-json: discard non-local inherent impls for primitives) - rust-lang#128559 (Don't re-elaborated already elaborated caller bounds in method probe) - rust-lang#128631 (handle crates when they are not specified for std docs) - rust-lang#128664 (Add `Debug` impls to API types in `rustc_codegen_ssa`) - rust-lang#128686 (fix the invalid argument type) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2024
Rollup merge of rust-lang#128664 - fuzzypixelz:add-codegen-ssa-debug-impls, r=lcnr Add `Debug` impls to API types in `rustc_codegen_ssa` Some types used in `rustc_codegen_ssa`'s interface traits are missing `Debug` impls. Though I did not smear `#[derive(Debug)]` all over the crate (some structs are quite large).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types used in
rustc_codegen_ssa's interface traits are missingDebugimpls. Though I did not smear#[derive(Debug)]all over the crate (some structs are quite large).