migrate thumb-none-qemu to rmake

[folkertdev]

tracking issue: #121876

I think this one is actually simpler than #128636, we invoke cargo run with the right target and see if the expected result appears.

r? @jieyouxu

try-job: armhf-gnu
try-job: dist-various-1
try-job: test-various

[rustbot]

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

[folkertdev]

that file notes that some targets are not quite accurate because qemu is too old. Maybe that has changed? we can try that separately though.

[jieyouxu]

Unfortunately, I have no clue what the up-to-date cargo config in this case is for thumb targets and I don't have the environment to set it, I'm fine with keeping the config as-is for now. If anyone knowledgeable about thumb can update that config, I would be happy to accept.

[folkertdev]

I've now updated the thumbv6m-none-eabi target to use the -cpu cortex-m0. We'll see if that causes issues, it shouldn't if the qemu version is remotely recent. Otherwise I think that config file looks fine.

[jieyouxu]

Ah hah, I see this is going to require some archaeology 😄 I'll take a look at this tmrw

[folkertdev]

yeah I've also added this to the agenda of the embedded-wg rust-embedded/wg#783, they might have thoughts on how big a deal this actually is.

[folkertdev]

I did some of the detective work: that file is 5 years old, so it is quite plausible that more things now work. With my qemu, cortex-m0 is now available. cortexm-23 is not. I was not able to build a version of qemu, so I'm not 100% sure that it's not supported.

> qemu-system-arm --version
QEMU emulator version 8.1.1
Copyright (c) 2003-2023 Fabrice Bellard and the QEMU Project developers

> qemu-system-arm -cpu help | grep "cortex"
  cortex-a15
  cortex-a7
  cortex-a8
  cortex-a9
  cortex-m0
  cortex-m3
  cortex-m33
  cortex-m4
  cortex-m55
  cortex-m7
  cortex-r5
  cortex-r52
  cortex-r5f

anyway, we can update that separately from switching to rmake, and given that it's apparently not caused issues over the last 5 years it's probably not a high priority.

[jieyouxu]

Thanks, this looks very reasonable. I'll run a couple of try jobs to check after not using the extra directory indirection.

[jieyouxu]

Self-remark:

set -exuo pipefail

cf. https://gist.github.com/mohanpedala/1e2ff5661761d3abd0385e8223e16425?permalink_comment_id=3935570

-e: immediately exit on non-zero
-x: all exec cmd printed to terminal
-u: strict no-undef variables modulo `$*` and `$@`
-o pipefail: prevent errors in pipelines from being masked

[jieyouxu]

Unfortunately, I have no clue what the up-to-date cargo config in this case is for thumb targets and I don't have the environment to set it, I'm fine with keeping the config as-is for now. If anyone knowledgeable about thumb can update that config, I would be happy to accept.

[jieyouxu]

Remark: I wonder if this needs LD_LIBRARY_PATH set.

[jieyouxu]

@bors try (just to see)

[jieyouxu]

@rustbot author

[bors]

⌛ Trying commit 54f40ce with merge 7084c9b...

[jieyouxu]

@rustbot blocked (pending T-compiler discussion)

[bors]

☀️ Try build successful - checks-actions
Build commit: 7084c9b (7084c9bc957727b458119a236606b59164ea79ad)

[folkertdev]

@rustbot ready

[folkertdev]

I've now updated the thumbv6m-none-eabi target to use the -cpu cortex-m0. We'll see if that causes issues, it shouldn't if the qemu version is remotely recent. Otherwise I think that config file looks fine.

[jieyouxu]

Thanks!
@bors r+

[bors]

📌 Commit 3e5885f has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3e5885f with merge f4b7051...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

💔 Test failed - checks-actions

[folkertdev]

looks like bors still has some issues?

  #1 28.11 error: failed to list workers: Unavailable: connection error: desc = "transport: Error while dialing: dial unix /run/buildkit/buildkitd.sock: connect: no such file or directory"
  #1 creating container buildx_buildkit_fervent_leavitt0 27.9s done
  #1 ERROR: exit code 1

[jieyouxu]

looks like bors still has some issues?

  #1 28.11 error: failed to list workers: Unavailable: connection error: desc = "transport: Error while dialing: dial unix /run/buildkit/buildkitd.sock: connect: no such file or directory"
  #1 creating container buildx_buildkit_fervent_leavitt0 27.9s done
  #1 ERROR: exit code 1

A different issue lol: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/CI.20failures.20from.20networking

[jieyouxu]

@bors r+

[bors]

📌 Commit 3e5885f has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3e5885f with merge 2048386...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 2048386 to master...

[rust-timer]

Finished benchmarking commit (2048386): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.1%, secondary 0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	3.8%	[3.8%, 3.8%]	1
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	0.1%	[-3.1%, 3.3%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 760.03s -> 761.822s (0.24%)
Artifact size: 337.08 MiB -> 337.08 MiB (0.00%)