Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update books #128354

Closed
wants to merge 2 commits into from
Closed

Update books #128354

wants to merge 2 commits into from

Conversation

rustbot
Copy link
Collaborator

@rustbot rustbot commented Jul 29, 2024

rust-lang/book

4 commits in 67fa536768013d9d5a13f3a06790521d511ef711..98dd2c1d7fbef0fdd4a377e4dbb7af71bbdc9bae
2024-07-23 14:12:54 UTC to 2024-07-16 18:18:38 UTC

rust-lang/rust-by-example

2 commits in 89aecb6951b77bc746da73df8c9f2b2ceaad494a..e691ace33d1479f015ad73a33f43abc338ae3039
2024-07-26 20:48:27 UTC to 2024-07-16 20:58:25 UTC

rust-lang/rustc-dev-guide

8 commits in 0c4d55cb59fe440d1a630e4e5774d043968edb3f..4765bd775d0c15781a5119b8521eba0975e145a9
2024-07-27 12:45:57 UTC to 2024-07-19 07:15:12 UTC

@rustbot
Copy link
Collaborator Author

rustbot commented Jul 29, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator Author

rustbot commented Jul 29, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling mdbook-trpl-listing v0.1.0 (/checkout/src/doc/book/packages/mdbook-trpl-listing)
error: hidden lifetime parameters in types are deprecated
   --> /checkout/src/doc/book/packages/mdbook-trpl-listing/src/lib.rs:160:18
    |
160 |             Ok::<ListingState, String>(state)
    |
    = note: `-D elided-lifetimes-in-paths` implied by `-D warnings`
    = note: `-D elided-lifetimes-in-paths` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(elided_lifetimes_in_paths)]`
    |
    |
160 |             Ok::<ListingState<'_>, String>(state)

error: hidden lifetime parameters in types are deprecated
   --> /checkout/src/doc/book/packages/mdbook-trpl-listing/src/lib.rs:193:30
    |
    |
193 |         tag: pulldown_cmark::CowStr,
    |              ----------------^^^^^^
    |              |
    |              expected lifetime parameter
    |
help: indicate the anonymous lifetime
    |
193 |         tag: pulldown_cmark::CowStr<'_>,

error: hidden lifetime parameters in types are deprecated
   --> /checkout/src/doc/book/packages/mdbook-trpl-listing/src/lib.rs:250:54
    |
    |
250 |     fn close_listing(&mut self, tag: pulldown_cmark::CowStr, mode: Mode) {
    |                                      ----------------^^^^^^
    |                                      |
    |                                      expected lifetime parameter
    |
help: indicate the anonymous lifetime
    |
250 |     fn close_listing(&mut self, tag: pulldown_cmark::CowStr<'_>, mode: Mode) {

error: could not compile `mdbook-trpl-listing` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:00:27
Build completed unsuccessfully in 0:00:27
+ set -e
+ cat /tmp/toolstate/toolstates.json
{"wasm-component-ld":"test-fail","lld-wrapper":"test-fail","rustbook":"build-fail"}
+ python3 ../x.py test --stage 2 check-tools
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
ERROR: Tool `book` was not recorded in tool state.
ERROR: Tool `nomicon` was not recorded in tool state.
ERROR: Tool `reference` was not recorded in tool state.
ERROR: Tool `rust-by-example` was not recorded in tool state.
ERROR: Tool `edition-guide` was not recorded in tool state.
ERROR: Tool `embedded-book` was not recorded in tool state.
  local time: Mon Jul 29 17:38:57 UTC 2024
  network time: Mon, 29 Jul 2024 17:38:57 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@ehuss ehuss closed this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants