Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ICE when auto trait has assoc ty in old solver #128160

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Don't ICE when auto trait has assoc ty in old solver #128160

merged 1 commit into from
Jul 25, 2024

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jul 24, 2024 •
edited
Loading

Kinda a pointless change to make, but it's observable w/o the feature gate, so let's just fix it. I reintroduced this ICE when I removed the "auto impl" kind from ImplSource in #112687.

Fixes #117829
Fixes #127746

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2024
@jackh726
Copy link
Member

r? jackh726

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 24, 2024

📌 Commit 0919d07 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 25, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2024
@bors
Auto merge of rust-lang#128169 - matthiaskrgr:rollup-ylsoq30, r=matth…
004e155 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#127054 (Reorder trait bound modifiers *after* `for<...>` binder in trait bounds)
 - rust-lang#127528 (Replace ASCII control chars with Unicode Control Pictures)
 - rust-lang#127872 (Migrate `pointer-auth-link-with-c`, `c-dynamic-rlib` and `c-dynamic-dylib` `run-make` tests to rmake)
 - rust-lang#128111 (Do not use question as label)
 - rust-lang#128160 (Don't ICE when auto trait has assoc ty in old solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1fda084 into rust-lang:master Jul 25, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2024
@rust-timer
Unrolled build for rust-lang#128160
e2df67a 
Rollup merge of rust-lang#128160 - compiler-errors:auto, r=jackh726

Don't ICE when auto trait has assoc ty in old solver

Kinda a pointless change to make, but it's observable w/o the feature gate, so let's just fix it. I reintroduced this ICE when I removed the "auto impl" kind from `ImplSource` in rust-lang#112687.

Fixes rust-lang#117829
Fixes rust-lang#127746
@rustbot rustbot added this to the 1.82.0 milestone Jul 25, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jul 25, 2024

@rust-timer build e2df67a

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e2df67a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.1% [3.1%, 3.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.1% [3.1%, 3.1%] 1

Cycles

Results (secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.74s -> 769.954s (-0.23%)
Artifact size: 328.91 MiB -> 328.91 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
7 participants
@compiler-errors @rustbot @jackh726 @bors @Kobzol @rust-timer @chenyukang