-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate rlib-format-packed-bundled-libs-2
, native-link-modifier-whole-archive
and no-builtins-attribute
run-make
tests to rmake
#128075
Conversation
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
247380b
to
c32db5c
Compare
☔ The latest upstream changes (presumably #127778) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors delegate+ (for try jobs) |
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
c32db5c
to
3347dfb
Compare
@bors try |
Migrate `rlib-format-packed-bundled-libs-2`, `native-link-modifier-whole-archive` and `no-builtins-attribute` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: test-various
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #128109) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot review (take a look at why the regex match failed on windows) |
b0fd23f
to
c5c6c0a
Compare
Looks like the symbol does appear... under a different format than Linux. Let's see if |
Migrate `rlib-format-packed-bundled-libs-2`, `native-link-modifier-whole-archive` and `no-builtins-attribute` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: test-various
☀️ Try build successful - checks-actions |
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, r=me if the additional round of try jobs come back green.
@bors try |
Migrate `rlib-format-packed-bundled-libs-2`, `native-link-modifier-whole-archive` and `no-builtins-attribute` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: x86_64-gnu-llvm-18
☀️ Try build successful - checks-actions |
@bors rollup=iffy (linker shenanigans) |
☀️ Test successful - checks-actions |
@rust-timer build 83dcdb3 |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (83dcdb3): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 769.659s -> 769.231s (-0.06%) |
Part of #121876 and the associated Google Summer of Code project.
Please try:
try-job: x86_64-msvc
try-job: test-various
try-job: armhf-gnu
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-18