Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest removing .unwrap() or .expect() if followed by a failed ? operator #127485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Suggest removing .unwrap() or .expect() if followed by a failed ? operator #127485

wants to merge 1 commit into from
+224 −0

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Jul 8, 2024

Closes #127345

@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2024

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 8, 2024
@bors
Copy link
Contributor

bors commented Jul 9, 2024

☔ The latest upstream changes (presumably #127493) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2024
@trevyn
Copy link
Contributor Author

trevyn commented Jul 11, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 11, 2024
fee1-dead
fee1-dead requested changes Jul 15, 2024
View reviewed changes
tests/ui/try-trait/try-after-unwrap-issue-127345.rs
Comment on lines +34 to +39
fn baz3() -> Option<usize> {
Ok(44).unwrap()?
//~^ ERROR the `?` operator can only be applied to values that implement `Try`
//~| HELP the trait `Try` is not implemented for `{integer}`
//~| HELP remove the `.unwrap()`
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In baz3 the suggestion shouldn't fire because removing the .unwrap does not help. You probably want to check that the return type of the function is compatible with the non-unwrapped reciever

tests/ui/try-trait/try-after-unwrap-issue-127345.rs
Comment on lines +41 to +48
fn baz4() {
Ok(44).unwrap()?
//~^ ERROR the `?` operator can only be applied to values that implement `Try`
//~| HELP the trait `Try` is not implemented for `{integer}`
//~| HELP remove the `.unwrap()`
//~| ERROR the `?` operator can only be used in a function that returns `Result` or `Option` (or another type that implements `FromResidual`)
//~| HELP the trait `FromResidual<_>` is not implemented for `()`
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. It is more likely that the ? was inserted on error and not .unwrap()

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2024
@bors
Copy link
Contributor

bors commented Jul 22, 2024

☔ The latest upstream changes (presumably #128041) made this pull request unmergeable. Please resolve the merge conflicts.

@lolbinarycat lolbinarycat added the A-diagnostics Area: Messages for errors, warnings, and lints label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect when ? is being called on a type *after* .unwrap or .expect was called on a Result or Option
6 participants
@trevyn @rustbot @bors @estebank @fee1-dead @lolbinarycat