Stop using specialization in rustc_index and rustc_borrowck

[bjorn3]

For rustc_borrowck the version with specialization isn't much more readable anyway IMO. For rustc_index it probably doesn't affect perf in any noticeable way anyway.

[rustbot]

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[bjorn3]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a592c58 with merge d18cecc...

[bors]

💔 Test failed - checks-actions

[bjorn3]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 449581d with merge 5452db1...

[bors]

☀️ Try build successful - checks-actions
Build commit: 5452db1 (5452db13e6283db414608c9b77d03f75da032072)

[rust-timer]

Finished benchmarking commit (5452db1): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 696.099s -> 696.641s (0.08%)
Artifact size: 324.69 MiB -> 324.61 MiB (-0.03%)

[michaelwoerister]

Thanks, @bjorn3!
@bors r+

[bors]

📌 Commit 449581d has been approved by michaelwoerister

It is now in the queue for this repository.

[bors]

⌛ Testing commit 449581d with merge 9f877c9...

[bors]

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 9f877c9 to master...

[rust-timer]

Finished benchmarking commit (9f877c9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-3.7%, -0.5%]	8
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 734.204s -> 723.44s (-1.47%)
Artifact size: 328.34 MiB -> 328.21 MiB (-0.04%)